Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism #1

Merged
merged 60 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism #1

merged 60 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 14, 2021 •
edited
Loading

Application plugin migration to use the new teardown mechanism

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

@andfoy andfoy changed the title PR: Application plugin teardown [spy-plugin-teardowm] PR: Application plugin teardown Jul 14, 2021
@andfoy andfoy changed the title [spy-plugin-teardowm] PR: Application plugin teardown [spy-plugin-registry-teardown] PR: Application plugin teardown Jul 14, 2021
@andfoy andfoy mentioned this pull request Jul 14, 2021
Merged
3 tasks
@andfoy andfoy force-pushed the application_plugin_teardown branch 2 times, most recently from 8c93b12 to a61c182 Compare July 14, 2021 23:49
@andfoy andfoy force-pushed the implement_plugin_teardown branch 2 times, most recently from f147a4f to 9a844b4 Compare July 15, 2021 00:04
@andfoy andfoy force-pushed the application_plugin_teardown branch from 310b02e to 22e1ba5 Compare July 15, 2021 00:04
This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the implement_plugin_teardown branch from 9a844b4 to 53c3c26 Compare July 15, 2021 18:05
@andfoy andfoy force-pushed the application_plugin_teardown branch 2 times, most recently from 3b5a323 to e6a4362 Compare July 15, 2021 19:28
@andfoy andfoy mentioned this pull request Jul 15, 2021
Merged
@andfoy andfoy changed the title [spy-plugin-registry-teardown] PR: Application plugin teardown [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
@andfoy andfoy force-pushed the application_plugin_teardown branch from e6a4362 to b920e4c Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the implement_plugin_teardown branch from 24407ef to aaefe8d Compare July 16, 2021 19:13
@andfoy andfoy force-pushed the application_plugin_teardown branch from b920e4c to 2f09972 Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the implement_plugin_teardown branch from aaefe8d to 3a2e341 Compare August 30, 2021 19:53
@andfoy andfoy force-pushed the application_plugin_teardown branch 2 times, most recently from 17113af to f1169f7 Compare August 30, 2021 22:00
@andfoy andfoy force-pushed the implement_plugin_teardown branch from 9c29b7e to d380d97 Compare August 31, 2021 17:24
andfoy added 27 commits October 6, 2021 14:22
@andfoy
Address review comments
1df611e
@andfoy
Migrate projects to use the new teardown mechanism
fbb6814
@andfoy
Update calls to remove_item_from_application_menu
5908d3b
@andfoy
Address review comments
8601e2e
@andfoy
Address further review comments
88e3b4a
@andfoy
Minor error correction
83907bc
@andfoy
Restore sig_stop_completions connection
861e324
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
6c6b22d
@andfoy
Remove hard reference to editor in pylint
690eb3c
@andfoy
Update calls to remove_item_from_application_menu
c4b0539
@andfoy
Address review comments
807f017
@andfoy
Final review comments
4d69705
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
64f18f9
@andfoy
Update calls to remove_item_from_application_menu
ac1c237
@andfoy
Address review comments
abe924d
@andfoy
Add proper signature to statusbar on_close method
718a1ac
@andfoy
Address review comments
22b75f6
@andfoy
Migrate variable explorer and working directory to use the new teardo…
08e5f98 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
f6192cf
@andfoy
Apply review comments
9fe8e0a
@andfoy
Remove duplicate on__close
6f66707
@andfoy
Add preference page to enable and disable plugins
aaf3295
@andfoy
Restart Spyder after a plugin is enabled/disabled
ee88227
@andfoy
Disable also Spyder 4 plugins
f123f7f
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
741c645
@andfoy
Address review comments
2c2feee
@andfoy
Always add external plugin metadata
9c5cb29
@andfoy andfoy merged commit 84747b2 into implement_plugin_teardown Oct 6, 2021
@andfoy andfoy deleted the application_plugin_teardown branch October 6, 2021 19:22
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12