Add multiple clustering resolution functionality #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camisowers
changed the title
# Conflicts: # tests/test_utils.py
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
camisowers
requested review from
srivarra and
alex-l-kong
and removed request for
srivarra
alex-l-kong
reviewed
Dec 20, 2023
| @@ -6,9 +6,10 @@ | |||
| "metadata": {}, | |||
There was a problem hiding this comment.
Is there a better way to do this other than raw printing everything out? At the very least, I think this should be formatted so it lists a separate cluster name per row.
Reply via ReviewNB
There was a problem hiding this comment.
Not really an automated way to do this since the user needs to manually define the cluster grouping dictionary. I'll fix it so it prints like below.
0 CD4T
1 CD8T
2 CD14_monocyte
3 Bcell
4 other
5 M2_macrophage
6 immune_other
7 M1_macrophage
8 APC
9 stroma
10 endothelium
11 Myofibroblast
12 tumor_ck17
13 tumor_ecad
Name: cell_meta_cluster, dtype: object
srivarra
requested changes
Dec 20, 2023
|
The ark tests are still failing, but can you just review the newest changes so it's ready to go once we get that fixed? @alex-l-kong @srivarra |
…ter_granularities
srivarra
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #1070.
How did you implement your changes
Add helper function to create a new clustering column in the cell table. Include in notebook 4 with a description of the necessary inputs.
Remaining issues
NA