Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

ui-tab didn't displayed correctly when use string index #5687

Closed
sukrosono opened this issue Mar 24, 2016 · 3 comments
Closed

ui-tab didn't displayed correctly when use string index #5687

sukrosono opened this issue Mar 24, 2016 · 3 comments

Comments

@sukrosono
Copy link

Bug description:

I am refering the doc:

index - Tab index. Must be unique

it's clearly work when use tab without index attribute, so i made the reproduction both.
Here the reproduction

Version of Angular, UIBS, and Bootstrap

angular version 1.5.0
uib 1.2.5
bootstrap 3.3.6
ngAnimate 1.4.2

@wesleycho
Copy link
Contributor

There is already a pull request (#5577) for implementing this.

I thought it's generally assumed one uses a number with an index, but I guess some people disagree...

@icfantv
Copy link
Contributor

icfantv commented Mar 24, 2016

I don't think that guy is going to get around to finishing that, we may need to enter a new PR.

@deeg deeg self-assigned this Mar 30, 2016
deeg pushed a commit to deeg/bootstrap that referenced this issue Mar 31, 2016
Allow Tab index to be a string

Closes angular-ui#5687
Closes angular-ui#5577
deeg pushed a commit to deeg/bootstrap that referenced this issue Mar 31, 2016
Allow Tab index to be a string

Closes angular-ui#5687
Closes angular-ui#5577
Closes angular-ui#5713
@wesleycho
Copy link
Contributor

Closing, as this is already addressed in a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants