Allow string as Tab index value #5577
Conversation
|
@vadim-p, i'm ok with this, but this is going to need tests and a documentation update as well. |
|
@vadim-p, this is a good feature, but we are unable to use this PR and will close it if you don't address the concerns previously mentioned. Thanks. |
|
We are also doing the isNumber check in the select and addTab functions. I'd like to get an opinion from @wesleycho on whether the index needs to be a number or we can just use isDefined instead? |
|
I assumed an index should be a number - I'm not hugely opinionated on whether it should be though, and am fine with changing that. @icfantv is right in what this PR needs though. |
|
Hello. Sorry for silence from my side - I'm traveling. I'll try to get back to you with updates in 3-4 days. Thank you. |
|
@vadim-p, awesome. Thanks. |
|
@vadim-p do you still intend on completing this? If not, we're going to close it. |
Allow Tab index to be a string Closes angular-ui#5687 Closes angular-ui#5577
Allow Tab index to be a string Closes angular-ui#5687 Closes angular-ui#5577 Closes angular-ui#5713
|
Closing due to lack of response. Replaced by #5713. |
Simple situation - when iterating hash, so hash key plays well as index.