Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mat-autocomplete autoActiveFirstOption sets aria-activedescendant when the autocomplete panel is closed #14453

Closed
ezettersten opened this issue Dec 10, 2018 · 1 comment · Fixed by #14455
Closed

mat-autocomplete autoActiveFirstOption sets aria-activedescendant when the autocomplete panel is closed #14453

ezettersten opened this issue Dec 10, 2018 · 1 comment · Fixed by #14455
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@ezettersten
Copy link

What is the expected behavior?

When the autocomplete panel is closed and autocomplete is autoActiveFirstOption enabled, the input should not have an aria-activedescendent attribute associated to it.

What is the current behavior?

With autoActiveFirstOption attribute added to mat-autocomplete, even when the panel is closed the autocomplete input has aria-activedescendant="[first-mat-option]"

What are the steps to reproduce?

https://stackblitz.com/edit/angular-nsonvp

  1. Focus into the autocomplete input.
  2. Blur away from the autocomplete input.
  3. inspect the input, you should see aria-activedescendant="mat-option-0" on the input element.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/material": "7.1.1"
"@angular/core": "7.1.2"
"@angular/cdk": "7.1.1"
"@angular/cli": "~7.0.2"

Is there anything else we should know?
@crisbeto crisbeto self-assigned this Dec 10, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Dec 10, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 10, 2018
@crisbeto
fix(autocomplete): adding aria-activedescendant while closed if autoA…
aba95e6 
…ctiveFirstOption is enabled

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
@crisbeto crisbeto mentioned this issue Dec 10, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 12, 2018
@crisbeto
fix(autocomplete): adding aria-activedescendant while closed if autoA…
8fb09f0 
…ctiveFirstOption is enabled

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 13, 2018
@crisbeto
fix(autocomplete): adding aria-activedescendant while closed if autoA…
c58c0eb 
…ctiveFirstOption is enabled

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 14, 2018
@crisbeto
fix(autocomplete): adding aria-activedescendant while closed if autoA…
398bb7d 
…ctiveFirstOption is enabled

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
jelbourn pushed a commit that referenced this issue Dec 20, 2018
@crisbeto @jelbourn
fix(autocomplete): adding aria-activedescendant while closed if autoA…
f3065cc 
…ctiveFirstOption is enabled (#14455)

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes #14453.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
@crisbeto @josephperrott
fix(autocomplete): adding aria-activedescendant while closed if autoA…
ad7528a 
…ctiveFirstOption is enabled (angular#14455)

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @ezettersten