Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): adding aria-activedescendant while closed if autoActiveFirstOption is enabled #14455

Merged
merged 1 commit into from
Dec 20, 2018
Merged

fix(autocomplete): adding aria-activedescendant while closed if autoActiveFirstOption is enabled #14455

merged 1 commit into from
Dec 20, 2018

Conversation

crisbeto
Copy link
Member

Fixes the autocomplete trigger setting its aria-activedescendant attribute while the panel is closed and the options aren't in the DOM, if the autoActiveFirstOption is enabled.

Fixes #14453.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Dec 10, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2018
@ngbot
Copy link

ngbot bot commented Dec 12, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 14453/autocomplete-closed-active-descendant branch from aba95e6 to 8fb09f0 Compare December 12, 2018 22:22
jelbourn
jelbourn approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@ngbot
Copy link

ngbot bot commented Dec 13, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the 14453/autocomplete-closed-active-descendant branch from 8fb09f0 to c58c0eb Compare December 13, 2018 17:48
@crisbeto
fix(autocomplete): adding aria-activedescendant while closed if autoA…
398bb7d 
…ctiveFirstOption is enabled

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
@crisbeto crisbeto force-pushed the 14453/autocomplete-closed-active-descendant branch from c58c0eb to 398bb7d Compare December 14, 2018 07:12
@jelbourn jelbourn merged commit f3065cc into angular:master Dec 20, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(autocomplete): adding aria-activedescendant while closed if autoA…
ad7528a 
…ctiveFirstOption is enabled (angular#14455)

Fixes the autocomplete trigger setting its `aria-activedescendant` attribute while the panel is closed and the options aren't in the DOM, if the `autoActiveFirstOption` is enabled.

Fixes angular#14453.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-autocomplete autoActiveFirstOption sets aria-activedescendant when the autocomplete panel is closed
3 participants
@crisbeto @jelbourn @googlebot