Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_theming.scss deprecation warnings #14636

Closed
emreyalvac opened this issue Dec 25, 2018 · 5 comments · Fixed by #14673
Closed

_theming.scss deprecation warnings #14636

emreyalvac opened this issue Dec 25, 2018 · 5 comments · Fixed by #14673
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@emreyalvac
Copy link

Deprecation warnings when get build

_theming.scss line 1404:

from -> @return if($font-family == null, $font-family, unquote($font-family));
to -> @return if($font-family == null, $font-family, $font-family);
@crisbeto
Copy link
Member

I'm not getting any warnings. What version of node-sass are you using?

@emreyalvac
Copy link
Author

4.11.0

@crisbeto crisbeto self-assigned this Dec 25, 2018
@crisbeto
Copy link
Member

crisbeto commented Dec 26, 2018 •
edited
Loading

I tried updating and testing it against our local dev app and a project generated with the CLI, but I wasn't able to reproduce the warning. Can you post the entire warning? Also it seems like the warning is coming from something in the typography utilities, could you post your typography config?

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Dec 29, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 29, 2018
@crisbeto
fix(typography): deprecation warning in latest sass version
43010cd 
* Updates to the latest `node-sass` version.
* Fixes the build not using the `node-sass` version from the package.json.
* Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string `font-family` (e.g. `Helvetica Neue`).

Fixes angular#14636.
@crisbeto crisbeto mentioned this issue Dec 29, 2018
Merged
@emreyalvac
Copy link
Author

fixed

mmalerba pushed a commit that referenced this issue Jan 4, 2019
@crisbeto @mmalerba
fix(typography): deprecation warning in latest sass version (#14673)
65ecb08 
* Updates to the latest `node-sass` version.
* Fixes the build not using the `node-sass` version from the package.json.
* Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string `font-family` (e.g. `Helvetica Neue`).

Fixes #14636.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
@crisbeto @josephperrott
fix(typography): deprecation warning in latest sass version (angular#…
4c0bb82 
…14673)

* Updates to the latest `node-sass` version.
* Fixes the build not using the `node-sass` version from the package.json.
* Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string `font-family` (e.g. `Helvetica Neue`).

Fixes angular#14636.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(typography): deprecation warning in latest sass version crisbeto/material2
2 participants
@crisbeto @emreyalvac