Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typography): deprecation warning in latest sass version #14673

Merged

Conversation

crisbeto
Copy link
Member

  • Updates to the latest node-sass version.
  • Fixes the build not using the node-sass version from the package.json.
  • Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string font-family (e.g. Helvetica Neue).

Fixes #14636.

* Updates to the latest `node-sass` version.
* Fixes the build not using the `node-sass` version from the package.json.
* Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string `font-family` (e.g. `Helvetica Neue`).

Fixes angular#14636.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 29, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 29, 2018
@nikeshjain
Copy link

nikeshjain commented Dec 29, 2018 via email

@mmalerba mmalerba merged commit 65ecb08 into angular:master Jan 4, 2019
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…14673)

* Updates to the latest `node-sass` version.
* Fixes the build not using the `node-sass` version from the package.json.
* Fixes a deprecation warning from the latest SASS version when the consumer has configured a non-string `font-family` (e.g. `Helvetica Neue`).

Fixes angular#14636.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_theming.scss deprecation warnings
6 participants