fix(google-maps): unable to subscribe to events after initialization #17845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 3, 2019
mbehrlich
suggested changes
Dec 4, 2019
As things are set up right now in the `google-map`, `map-marker` and `map-info-window` components we choose whether to bind an event based on whether there are subscribers to its observable. The problem is that if the user decides to subscribe after init (e.g. by getting a hold of object with `ViewChild` and subscribing) it'll never emit because the native event wasn't added. These changes fix the issue by switching the event to be observables and binding the event when something has subscribed. I've also introduced a `MapEventManager` class to make it easier to keep track of the events and to avoid duplication between the three components.
crisbeto
force-pushed
the
map-events-after-init
branch
from
2de37ac to
1758d40
Compare
|
I've addressed the feedback @jelbourn @mbehrlich. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 22, 2019
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 22, 2019
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped. Fixes angular#18026.
This was referenced Dec 22, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As things are set up right now in the
google-map,map-markerandmap-info-windowcomponents we choose whether to bind an event based on whether there are subscribers to its observable. The problem is that if the user decides to subscribe after init (e.g. by getting a hold of object withViewChildand subscribing) it'll never emit because the native event wasn't added.These changes fix the issue by switching the event to be observables and binding the event when something has subscribed. I've also introduced a
MapEventManagerclass to make it easier to keep track of the events and to avoid duplication between the three components.