Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google-maps): incorrect event name #18027

Merged
merged 1 commit into from
Jan 6, 2020
Merged

fix(google-maps): incorrect event name #18027

merged 1 commit into from
Jan 6, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 22, 2019 •
edited
Loading

Looks like a regression from #17845 where the name of the zoom_changed event was mistyped.

Fixes #18026.

@crisbeto
fix(google-maps): incorrect event name
788223b 
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped.

Fixes angular#18026.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 22, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 22, 2019
@crisbeto crisbeto mentioned this pull request Dec 22, 2019
Closed
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 31, 2019
@mmalerba mmalerba merged commit f2cbc06 into angular:master Jan 6, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
fix(google-maps): incorrect event name (angular#18027)
8a9124e 
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped.

Fixes angular#18026.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[googlemaps] - zoomChanged -> zoom_changed
5 participants
@crisbeto @devversion @jelbourn @googlebot @mmalerba