Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[googlemaps] - zoomChanged -> zoom_changed #18026

Closed
AerisG222 opened this issue Dec 21, 2019 · 3 comments · Fixed by #18027
Closed

[googlemaps] - zoomChanged -> zoom_changed #18026

AerisG222 opened this issue Dec 21, 2019 · 3 comments · Fixed by #18027
Assignees
@crisbeto
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@AerisG222
Copy link

When using "@angular/google-maps": "^9.0.0-rc.0", the zoomChanged event never fires.

Currently, google-map.ts:222 reads as follows:

@output() zoomChanged: Observable = this._eventManager.getLazyEmitter('zoomChanged');

However, based on the related google docs (which is nicely commented on line 220: https://developers.google.com/maps/documentation/javascript/reference/map#Map.zoom_changed) it looks like the event name should be "zoom_changed" rather than "zoomChanged".
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 22, 2019
@crisbeto
fix(google-maps): incorrect event name
788223b 
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped.

Fixes angular#18026.
@crisbeto crisbeto mentioned this issue Dec 22, 2019
Merged
@crisbeto
Copy link
Member

crisbeto commented Dec 22, 2019 •
edited
Loading

Sorry about that, it looks like I messed up the name when I was redoing the way events are managed in #17845. This'll be fixed by #18027.

@crisbeto crisbeto self-assigned this Dec 22, 2019
@crisbeto crisbeto added has pr P2 The issue is important to a large percentage of users, with a workaround labels Dec 22, 2019
@AerisG222
Copy link
Author

No worries - thanks for all the work you have put into this!

mmalerba pushed a commit that referenced this issue Jan 6, 2020
@crisbeto @mmalerba
fix(google-maps): incorrect event name (#18027)
f2cbc06 
Looks like a regression from #17845 where the name of the `zoom_changed` even was mistyped.

Fixes #18026.
yifange pushed a commit to yifange/components that referenced this issue Jan 30, 2020
@crisbeto @yifange
fix(google-maps): incorrect event name (angular#18027)
8a9124e 
Looks like a regression from angular#17845 where the name of the `zoom_changed` even was mistyped.

Fixes angular#18026.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(google-maps): incorrect event name crisbeto/material2
2 participants
@AerisG222 @crisbeto