Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDC Chips] Chips with leading icon do not render properly when initially selected. #17979

Closed
andrewseguin opened this issue Dec 16, 2019 · 1 comment · Fixed by #17997, lingounet/testage#9, hrueger/AGLight#112 or hrueger/AGLight#114
Closed

[MDC Chips] Chips with leading icon do not render properly when initially selected. #17979

andrewseguin opened this issue Dec 16, 2019 · 1 comment · Fixed by #17997, lingounet/testage#9, hrueger/AGLight#112 or hrueger/AGLight#114
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@andrewseguin
Copy link
Contributor

Reproduction

https://stackblitz.com/edit/components-issue-d9exgw?file=app%2Fapp.component.scss

Expected Behavior

Pet Friendly should not have an empty space for the avatar

Actual Behavior

The checkmark shows an empty place beside it since the leading icon is not hidden.
@crisbeto crisbeto self-assigned this Dec 18, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Dec 18, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 18, 2019
@crisbeto
fix(material-experimental/mdc-chips): leading icon not hidden on init…
4c26ddc 
… when preselected

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes angular#17979.
@crisbeto crisbeto mentioned this issue Dec 18, 2019
Merged
jelbourn pushed a commit that referenced this issue Jan 29, 2020
@crisbeto
fix(material-experimental/mdc-chips): leading icon not hidden on init…
4c08a88 
… when preselected (#17997)

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes #17979.
yifange pushed a commit to yifange/components that referenced this issue Jan 30, 2020
@crisbeto @yifange
fix(material-experimental/mdc-chips): leading icon not hidden on init…
9b7680a 
… when preselected (angular#17997)

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes angular#17979.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @andrewseguin