Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-chips): leading icon not hidden on init when preselected #17997

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

crisbeto
Copy link
Member

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes #17979.

… when preselected

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes angular#17979.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 18, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner December 18, 2019 11:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: merge safe labels Jan 27, 2020
@jelbourn jelbourn merged commit 4c08a88 into angular:master Jan 29, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
… when preselected (angular#17997)

Fixes the leading icon of a preselected chip not being hidden on init.

Fixes angular#17979.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MDC Chips] Chips with leading icon do not render properly when initially selected.
4 participants