-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(mat-select): Option overlay is misaligned if 'disableOptionCentering' is true and selected/first option is under an options group #21570
Labels
area: material/select
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
koccs
added a commit
to koccs/components
that referenced
this issue
Jan 27, 2021
…centering Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
koccs
added a commit
to koccs/components
that referenced
this issue
Jan 27, 2021
…centering Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
koccs
added a commit
to koccs/components
that referenced
this issue
Jan 27, 2021
…centering Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
koccs
added a commit
to koccs/components
that referenced
this issue
Jan 27, 2021
…centering Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this issue
Feb 8, 2021
…centering (angular#21716) Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this issue
Feb 8, 2021
…centering (angular#21716) Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: material/select
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Reproduction
Example: https://stackblitz.com/edit/angular-vzpglv
Steps to reproduce:
mat-select
with enableddisableOptionCentering
SELECT_PANEL_INDENT_PADDING_X
here: https://github.com/angular/components/blob/master/src/material/select/select.ts#L1287Expected Behavior
If the
disableOptionCentering
is turned on then the_calculateOverlayOffsetX()
method should use theSELECT_PANEL_PADDING_X
even if the first/selected option is under a group.Actual Behavior
_calculateOverlayOffsetX()
method uses theSELECT_PANEL_INDENT_PADDING_X
every time if the first/selected option is under a group.Environment
This seems easy to fix with and additional condition in the
_calculateOverlayOffsetX()
likeif(this.multiple)
. If you guys agree with my assumptions I would like to fix it.The text was updated successfully, but these errors were encountered: