-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/select): overlay offset calculation for disabled option centering #21716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Can be marked as ready when the dev app adjustments have been made.
…centering Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…centering (angular#21716) Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
…centering (angular#21716) Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true. The overlay should not have double offset value for any selected option to keep it under the trigger element. Fixes angular#21570
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a the overlay offset calculation for grouped option values if
disableOptionCentering
is true.The overlay should not have double offset value for any selected option to keep it under the
trigger element.
Fixes #21570