Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/select): overlay offset calculation for disabled option centering #21716

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

koccs
Copy link
Contributor

@koccs koccs commented Jan 27, 2021

Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true.
The overlay should not have double offset value for any selected option to keep it under the
trigger element.

Fixes #21570

@koccs koccs requested a review from crisbeto as a code owner January 27, 2021 08:35
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 27, 2021
@koccs koccs requested a review from a team as a code owner January 27, 2021 08:47
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Can be marked as ready when the dev app adjustments have been made.

…centering

Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true.
The overlay should not have double offset value for any selected option to keep it under the
trigger element.

Fixes angular#21570
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 27, 2021
@wagnermaciel wagnermaciel merged commit da1f7e7 into angular:master Feb 1, 2021
wagnermaciel pushed a commit that referenced this pull request Feb 1, 2021
…centering (#21716)

Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true.
The overlay should not have double offset value for any selected option to keep it under the
trigger element.

Fixes #21570

(cherry picked from commit da1f7e7)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…centering (angular#21716)

Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true.
The overlay should not have double offset value for any selected option to keep it under the
trigger element.

Fixes angular#21570
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…centering (angular#21716)

Fixes a the overlay offset calculation for grouped option values if disableOptionCentering is true.
The overlay should not have double offset value for any selected option to keep it under the
trigger element.

Fixes angular#21570
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
3 participants