Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mdc-dialog): afterClosed observable no longer in the NgZone #21696

Closed
mmalerba opened this issue Jan 25, 2021 · 1 comment · Fixed by #21702
Closed

bug(mdc-dialog): afterClosed observable no longer in the NgZone #21696

mmalerba opened this issue Jan 25, 2021 · 1 comment · Fixed by #21702
Assignees
@crisbeto
Labels
area: material/dialog G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround

Comments

@mmalerba
Copy link
Contributor

mmalerba commented Jan 25, 2021 •
edited
Loading

We got an internal bug report about this:

Observed behavior

Prior the MDC migration the following router navigation was happening inside of the NgZone.
After migration to MDC, this navigation is no longer happening in the NgZone.

Expected behavior

Callbacks for the afterClosed Observable should be in the NgZone

Steps to reproduce

  1. Open a dialog
  2. Subscribe to afterClosed()
  3. Navigate within the callback, the Route complains that it is not in the NgZone
@mmalerba mmalerba added needs triage This issue needs to be triaged by the team area: material/dialog G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround and removed needs triage This issue needs to be triaged by the team labels Jan 25, 2021
@crisbeto crisbeto self-assigned this Jan 25, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 26, 2021
@crisbeto
fix(material-experimental/mdc-dialog): afterClosed being run outside …
2250011 
…of NgZone

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
@crisbeto crisbeto mentioned this issue Jan 26, 2021
Merged
wagnermaciel pushed a commit that referenced this issue Feb 1, 2021
@crisbeto
fix(material-experimental/mdc-dialog): afterClosed being run outside …
57c68e8 
…of NgZone (#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes #21696.
wagnermaciel pushed a commit that referenced this issue Feb 1, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
698d6d0 
…of NgZone (#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes #21696.

(cherry picked from commit 57c68e8)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
bf25254 
…of NgZone (angular#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Feb 8, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
06343ab 
…of NgZone (angular#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/dialog G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material-experimental/mdc-dialog): afterClosed being run outside of NgZone crisbeto/material2
2 participants
@crisbeto @mmalerba