Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-dialog): afterClosed being run outside of NgZone #21702

Merged
merged 1 commit into from
Feb 1, 2021
Merged

fix(material-experimental/mdc-dialog): afterClosed being run outside of NgZone #21702

merged 1 commit into from
Feb 1, 2021

Conversation

crisbeto
Copy link
Member

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run outside of the NgZone.

Fixes #21696.

@crisbeto
fix(material-experimental/mdc-dialog): afterClosed being run outside …
2250011 
…of NgZone

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jan 26, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 26, 2021
mmalerba
mmalerba approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker labels Jan 26, 2021
jelbourn
jelbourn approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 57c68e8 into angular:master Feb 1, 2021
wagnermaciel pushed a commit that referenced this pull request Feb 1, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
698d6d0 
…of NgZone (#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes #21696.

(cherry picked from commit 57c68e8)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
bf25254 
…of NgZone (angular#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): afterClosed being run outside …
06343ab 
…of NgZone (angular#21702)

Fixes that all of the callbacks tied to animations within the MDC-based dialog were being run
outside of the `NgZone`.

Fixes angular#21696.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mdc-dialog): afterClosed observable no longer in the NgZone
4 participants
@crisbeto @jelbourn @mmalerba @wagnermaciel