Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-input-container with md-prefix produces unexpected DOM #5643

Closed
parker-mike opened this issue Jul 10, 2017 · 2 comments · Fixed by #5647
Closed

md-input-container with md-prefix produces unexpected DOM #5643

parker-mike opened this issue Jul 10, 2017 · 2 comments · Fixed by #5647
Assignees
@crisbeto

Comments

@parker-mike
Copy link

Bug,
<md-input-container> <span md-prefix> <md-icon>home</md-icon> </span> <input mdInput name="givenName" readonly disabled> </md-input-container>
gives wrong DOM, div.mat-input-prefix is empty while the span.md-prefix is generated inside div.mat-input-infix
could be seen on the following plnkr:
http://plnkr.co/edit/WRtJEaWx0ilHPBeGLSM5?p=preview
which is regression from beta.6 on 4.1.3:
http://plnkr.co/edit/dGxYTBaObsjDs557jM4k?p=preview
@willshowell
Copy link
Contributor

mdPrefix works instead of md-prefix though I don't totally understand it

@crisbeto crisbeto self-assigned this Jul 10, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 10, 2017
@crisbeto
fix(input): missing selector for mdPrefix
d609719 
Fixes uses of `md-prefix` and `md-suffix` not being projected to the proper place in the DOM.

Fixes angular#5643.
@crisbeto crisbeto mentioned this issue Jul 10, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 12, 2017
@crisbeto
refactor(input): deprecate dash-case selectors
efacdfe 
Removes the `md-prefix` and `md-suffix` selectors from their respective directives.

BREAKING CHANGES: Any uses of `md-prefix` and `md-suffix` should be switched over to `mdPrefix` and `mdSuffix`.

Fixes angular#5643.
jelbourn pushed a commit that referenced this issue Jul 13, 2017
@crisbeto @jelbourn
refactor(input): deprecate dash-case selectors
8f0897f 
Removes the `md-prefix` and `md-suffix` selectors from their respective directives.

BREAKING CHANGES: Any uses of `md-prefix` and `md-suffix` should be switched over to `mdPrefix` and `mdSuffix`.

Fixes #5643.
jelbourn pushed a commit that referenced this issue Jul 14, 2017
@crisbeto @jelbourn
refactor(input): deprecate dash-case selectors (#5647)
7e8234b 
Removes the `md-prefix` and `md-suffix` selectors from their respective directives.

BREAKING CHANGES: Any uses of `md-prefix` and `md-suffix` should be switched over to `mdPrefix` and `mdSuffix`.

Fixes #5643.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(input): remove dash-case selectors for mdPrefix and mdSuffix crisbeto/material2
3 participants
@crisbeto @willshowell @parker-mike