refactor(input): remove dash-case selectors for mdPrefix and mdSuffix #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 10, 2017
src/lib/input/input-container.html
Outdated
| @@ -23,7 +23,7 @@ | |||
| </div> | |||
|
|
|||
| <div class="mat-input-suffix" *ngIf="_suffixChildren.length"> | |||
| <ng-content select="[mdSuffix], [matSuffix]"></ng-content> | |||
| <ng-content select="[mdSuffix], [matSuffix], [md-suffix]"></ng-content> | |||
There was a problem hiding this comment.
Can we just remove the dash-case selectors at this point?
There was a problem hiding this comment.
I suppose, I wasn't sure what the plan for deprecating them was.
There was a problem hiding this comment.
Looks like they're not used inside google, so should be safe to remove
Removes the `md-prefix` and `md-suffix` selectors from their respective directives. BREAKING CHANGES: Any uses of `md-prefix` and `md-suffix` should be switched over to `mdPrefix` and `mdSuffix`. Fixes angular#5643.
crisbeto
force-pushed
the
5643/prefix-selector
branch
from
d609719 to
efacdfe
Compare
crisbeto
changed the title
|
Re-purposed the PR to deprecate the dash-case selectors @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
jelbourn
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
md-prefixandmd-suffixselectors from their respective directives.BREAKING CHANGES: Any uses of
md-prefixandmd-suffixshould be switched over tomdPrefixandmdSuffix.Fixes #5643.