Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): flexible overlay with push not handling scroll offset and position locking #11421

Merged
merged 1 commit into from
May 31, 2018
Merged

fix(overlay): flexible overlay with push not handling scroll offset and position locking #11421

merged 1 commit into from
May 31, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes the position of flexible overlays with pushing enabled being thrown off once the user starts scrolling.
  • Fixes flexible overlays with pushing not handling locked positioning. With these changes locked overlays will only be pushed when they're opened, whereas non-locked overlays will stay in the viewport, even when the user scrolls down.
  • Fixes a potential issue due to a couple of variables being initialized together where one is set to zero and the other one is undefined.

Fixes #11365.

@crisbeto crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label May 20, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2018
@crisbeto
Copy link
Member Author

Marked as P2, because the current behavior ends up being a regression in the menu component.

jelbourn
jelbourn approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 22, 2018
@ngbot
Copy link

ngbot bot commented May 22, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the 11365/flexible-overlay-push-scroll branch from 800a924 to 103185c Compare May 23, 2018 20:28
@crisbeto
fix(overlay): flexible overlay with push not handling scroll offset a…
33b717a 
…nd position locking

* Fixes the position of flexible overlays with pushing enabled being thrown off once the user starts scrolling.
* Fixes flexible overlays with pushing not handling locked positioning. With these changes locked overlays will only be pushed when they're opened, whereas non-locked overlays will stay in the viewport, even when the user scrolls down.
* Fixes a potential issue due to a couple of variables being initialized together where one is set to zero and the other one is undefined.

Fixes angular#11365.
@crisbeto crisbeto force-pushed the 11365/flexible-overlay-push-scroll branch from 103185c to 33b717a Compare May 31, 2018 07:13
@josephperrott josephperrott merged commit 55aaa03 into angular:master May 31, 2018
josephperrott pushed a commit that referenced this pull request May 31, 2018
@crisbeto @josephperrott
fix(overlay): flexible overlay with push not handling scroll offset a…
74bbc30 
…nd position locking (#11421)
josephperrott added a commit that referenced this pull request Jun 1, 2018
@josephperrott
Revert "fix(overlay): flexible overlay with push not handling scroll …
60fe121 
…offset and position locking (#11421)"

This reverts commit 55aaa03.
@josephperrott josephperrott mentioned this pull request Jun 1, 2018
Merged
josephperrott added a commit that referenced this pull request Jun 1, 2018
@josephperrott
Revert "fix(overlay): flexible overlay with push not handling scroll …
9f6aa84 
…offset and position locking (#11421)" (#11622)
josephperrott added a commit that referenced this pull request Jun 1, 2018
@josephperrott
Revert "fix(overlay): flexible overlay with push not handling scroll …
c536d65 
…offset and position locking (#11421)" (#11622)
This was referenced Jun 2, 2018
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu positioning going wrong on scroll
4 participants
@crisbeto @jelbourn @googlebot @josephperrott