Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(overlay): flexible overlay with push not handling scroll offset and position locking" #11622

Merged

Conversation

josephperrott
Copy link
Member

Reverts #11421 due to internal test issues.

…offset and position locking (#11421)"

This reverts commit 55aaa03.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2018
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Jun 1, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 1, 2018
@josephperrott josephperrott merged commit 9f6aa84 into master Jun 1, 2018
@josephperrott josephperrott deleted the revert-11421-11365/flexible-overlay-push-scroll branch June 1, 2018 20:02
josephperrott added a commit that referenced this pull request Jun 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants