Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material-experimental): add autocomplete test harness #16620

Merged
merged 1 commit into from
Aug 29, 2019
Merged

feat(material-experimental): add autocomplete test harness #16620

merged 1 commit into from
Aug 29, 2019

Conversation

crisbeto
Copy link
Member

  • Adds a test harness for mat-autocomplete.
  • Fixes the global element locator not working for TestBed elements.
  • Adds the ability to get a property of a TestElement.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2019
@crisbeto crisbeto force-pushed the autocomplete-test-harness branch 4 times, most recently from 7de6851 to c517e86 Compare July 26, 2019 21:28
@crisbeto crisbeto marked this pull request as ready for review July 26, 2019 21:30
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Jul 26, 2019
@crisbeto crisbeto force-pushed the autocomplete-test-harness branch from c517e86 to 55f9cdc Compare July 27, 2019 05:37
@crisbeto crisbeto force-pushed the autocomplete-test-harness branch 3 times, most recently from bb49ecc to 61e204e Compare August 3, 2019 11:05
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 7, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
a451039 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
@crisbeto crisbeto mentioned this pull request Aug 7, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 7, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
7889ec7 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 7, 2019
@crisbeto @devversion
fix(material-experimental): unit tests getting wrong root element and…
3c87bee 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 7, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
06b0d0a 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 7, 2019
@crisbeto @devversion
fix(material-experimental): unit tests getting wrong root element and…
23ee4fb 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 7, 2019
@crisbeto @devversion
fix(material-experimental): unit tests getting wrong root element and…
06542d1 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
devversion pushed a commit to devversion/material2 that referenced this pull request Aug 15, 2019
@crisbeto @devversion
fix(material-experimental): unit tests getting wrong root element and…
64cd932 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
jelbourn
jelbourn reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option harness in a follow-up?

crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
433cfe5 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
d5dd0a0 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
2c2757f 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
8dd52a8 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
0cb3c82 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
b12ed29 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2019
@crisbeto
fix(material-experimental): unit tests getting wrong root element and…
adb5881 
… add API for getting property value

Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
mmalerba pushed a commit that referenced this pull request Aug 22, 2019
@crisbeto @mmalerba
fix(material-experimental): unit tests getting wrong root element and…
5194bea 
… add API for getting property value (#16706)

Based on the discussion in #16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in #16620.

* Fixes querying for elements outside the harness not working, because the wrong root node was set.
* Adds an API to retrieve the value of a property on a DOM node.
@jelbourn
Copy link
Member

@crisbeto was this one still blocked on anything?

@crisbeto
Copy link
Member Author

I don't think it is @jelbourn, I just need to rebase it.

@crisbeto crisbeto force-pushed the autocomplete-test-harness branch from 61e204e to 319cc2f Compare August 29, 2019 17:07
@crisbeto crisbeto requested a review from a team as a code owner August 29, 2019 17:07
@crisbeto
Copy link
Member Author

Rebased @jelbourn.

@crisbeto crisbeto force-pushed the autocomplete-test-harness branch 2 times, most recently from e50e5e9 to b999570 Compare August 29, 2019 17:13
jelbourn
jelbourn reviewed Aug 29, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than existing comments from me and Miles

@crisbeto crisbeto force-pushed the autocomplete-test-harness branch from b999570 to 64f4c50 Compare August 29, 2019 18:11
@crisbeto
Copy link
Member Author

The discussion around getAttribute and getProperty was resolved by #16706. I've addressed the rest of the comments as well.

@crisbeto
feat(material-experimental): add autocomplete test harness
8fc3cb9 
* Adds a test harness for `mat-autocomplete`.
* Fixes the global element locator not working for `TestBed` elements.
* Adds the ability to get a property of a `TestElement`.
@crisbeto crisbeto force-pushed the autocomplete-test-harness branch from 64f4c50 to 8fc3cb9 Compare August 29, 2019 18:14
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Aug 29, 2019
jelbourn
jelbourn approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 29, 2019
@jelbourn jelbourn merged commit 55e3d1e into angular:master Aug 29, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 8, 2019
@crisbeto
fix(material-experimental): use harnesses for mat-option
bff2df7 
Follow-up from angular#16620 and angular#16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`.

Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
@crisbeto crisbeto mentioned this pull request Sep 8, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 22, 2019
@crisbeto
fix(material-experimental): use harnesses for mat-option
3979a6f 
Follow-up from angular#16620 and angular#16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`.

Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 22, 2019
@crisbeto
fix(material-experimental): use harnesses for mat-option
b3348e9 
Follow-up from angular#16620 and angular#16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`.

Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 25, 2019
@crisbeto
fix(material-experimental): use harnesses for mat-option
31626e7 
Follow-up from angular#16620 and angular#16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`.

Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
andrewseguin pushed a commit that referenced this pull request Sep 27, 2019
@crisbeto @andrewseguin
fix(material-experimental): use harnesses for mat-option (#17009)
f084f13 
Follow-up from #16620 and #16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`.

Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @mmalerba @googlebot