fix(material-experimental): throw better error when trying to use fixture after it has been destroyed #17058
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Sep 11, 2019
crisbeto
force-pushed
the
harness-cd-after-destroy
branch
3 times, most recently
from
c04a1d0 to
929cb6c
Compare
|
I've switched it to an error based on the discussion @mmalerba. Can you take another look? |
crisbeto
force-pushed
the
harness-cd-after-destroy
branch
from
929cb6c to
55baae1
Compare
crisbeto
changed the title
mmalerba
added
pr: lgtm
action: merge
|
@crisbeto could you rebase? |
…ture after it has been destroyed Currently before most operations in the harnesses we call `fixture.detectChange`, however doing so on a destroyed fixture throws a vague error. These changes throw a custom error that should be easier to follow.
crisbeto
force-pushed
the
harness-cd-after-destroy
branch
from
55baae1 to
17c951d
Compare
|
Rebased. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
…ture after it has been destroyed (angular#17058) Currently before most operations in the harnesses we call `fixture.detectChange`, however doing so on a destroyed fixture throws a vague error. These changes throw a custom error that should be easier to follow. (cherry picked from commit 66c8708)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently before most operations in the harnesses we call
fixture.detectChange, however doing so on a destroyed fixture throws a vague error. These changes throw a custom error that should be easier to follow.