Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental): throw better error when trying to use fixture after it has been destroyed #17058

Merged
merged 1 commit into from
Sep 18, 2019
Merged

fix(material-experimental): throw better error when trying to use fixture after it has been destroyed #17058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/cdk/testing/testbed/testbed-harness-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ import {UnitTestElement} from './unit-test-element';

/** A `HarnessEnvironment` implementation for Angular's Testbed. */
export class TestbedHarnessEnvironment extends HarnessEnvironment<Element> {
private _destroyed = false;

protected constructor(rawRootElement: Element, private _fixture: ComponentFixture<unknown>) {
super(rawRootElement);
_fixture.componentRef.onDestroy(() => this._destroyed = true);
}

/** Creates a `HarnessLoader` rooted at the given fixture's root element. */
Expand Down Expand Up @@ -62,6 +65,10 @@ export class TestbedHarnessEnvironment extends HarnessEnvironment<Element> {
}

private async _stabilize(): Promise<void> {
if (this._destroyed) {
throw Error('Harness is attempting to use a fixture that has already been destroyed.');
}

this._fixture.detectChanges();
await this._fixture.whenStable();
}
Expand Down