Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to angular v9.0.0-rc.11 #18283

Merged
merged 1 commit into from
Jan 26, 2020
Merged

build: update to angular v9.0.0-rc.11 #18283

merged 1 commit into from
Jan 26, 2020

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 24, 2020 •
edited
Loading

Updates to the latest RC that includes
angular/angular@4eeb6cf. PR is needed to unblock @kseamon

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2020
@devversion
build: update to angular v9.0.0-rc.11
d6c621e 
Updates to the latest RC that includes
angular/angular@4eeb6cf.
@devversion devversion force-pushed the build/update-to-latest-rc branch from fb9f7aa to d6c621e Compare January 25, 2020 09:56
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed in progress labels Jan 25, 2020
@devversion devversion marked this pull request as ready for review January 25, 2020 10:02
@devversion devversion requested review from jelbourn and a team as code owners January 25, 2020 10:02
@devversion
Copy link
Member Author

PR is now ready. The test failure (for focus) seemed to be a flake.. but I wanted to make sure it was not related to the Angular update at all.

crisbeto
crisbeto approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 25, 2020
@jelbourn jelbourn merged commit e37b5e5 into angular:master Jan 26, 2020
@Splaktar
Copy link
Member

@jelbourn this should be cherry picked to the 9.0.x branch as well?

@Splaktar Splaktar mentioned this pull request Jan 27, 2020
Merged
jelbourn pushed a commit that referenced this pull request Jan 27, 2020
@devversion @jelbourn
build: update to angular v9.0.0-rc.11 (#18283)
38d9749 
Updates to the latest RC that includes
angular/angular@4eeb6cf.

(cherry picked from commit e37b5e5)
@jelbourn
Copy link
Member

Done

yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: update to angular v9.0.0-rc.11 (angular#18283)
2e63385 
Updates to the latest RC that includes
angular/angular@4eeb6cf.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @Splaktar @jelbourn @crisbeto @googlebot