Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

build: update to Angular 9.0.0-rc.11 and CLI 9.0.0-rc.10 #706

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

Splaktar
Copy link
Member

This currently results in the following build error:

ERROR in ./node_modules/@angular/components-examples/fesm2015/material/form-field.js 369:8-23
"export 'ɵɵallocHostVars' was not found in '@angular/core'

A prod build gives a bit more detail:

ERROR in ./node_modules/@angular/components-examples/fesm2015/material/form-field.js 324:16-31
"export 'ɵɵallocHostVars' was not found in '@angular/core'
    at HarmonyImportSpecifierDependency._getErrors (/Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:109:11)
    at HarmonyImportSpecifierDependency.getErrors (/Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:68:16)
    at Compilation.reportDependencyErrorsAndWarnings (/Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compilation.js:1463:22)
    at /Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compilation.js:1258:10
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/splaktar/Git/angular/material.angular.io/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:42:1)
    at AsyncSeriesHook.lazyCompileHook (/Users/splaktar/Git/angular/material.angular.io/node_modules/tapable/lib/Hook.js:154:20)
    at Compilation.finish (/Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compilation.js:1253:28)
    at /Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compiler.js:672:17
    at _done (eval at create (/Users/splaktar/Git/angular/material.angular.io/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at eval (eval at create (/Users/splaktar/Git/angular/material.angular.io/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:36:22)
    at /Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compilation.js:1185:12
    at /Users/splaktar/Git/angular/material.angular.io/node_modules/webpack/lib/Compilation.js:1097:9
    at processTicksAndRejections (internal/process/task_queues.js:76:11)
 @ ./node_modules/@angular/components-examples/fesm2015/components-examples.js
 @ ./src/app/pages/component-sidenav/component-sidenav.ts
 @ ./src/app/routes.ts
 @ ./src/app/app-module.ts
 @ ./src/main.ts
 @ multi ./src/main.ts
error Command failed with exit code 1.

@Splaktar
Copy link
Member Author

Possibly related to PR angular/components#18283 not getting cherry picked into the 9.0.x branch.

@Splaktar
Copy link
Member Author

I can't find any breaking change docs or notes about changes to https://next.angular.io/api/core/Directive#host relative to version 9 or rc.11.

This same example seems to build with Angular 9.0.0-rc.11 in the dev-app using Ivy.

@Splaktar Splaktar force-pushed the update-dependencies branch from e32fdc3 to ce79f11 Compare January 27, 2020 19:38
@Splaktar
Copy link
Member Author

Splaktar commented Jan 27, 2020

Fixed issues via updating to latest docs-content that includes PR angular/components#18300 which trigged this commit.

@Splaktar Splaktar marked this pull request as ready for review January 27, 2020 19:46
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 8a4640a into angular:master Jan 27, 2020
@Splaktar Splaktar deleted the update-dependencies branch January 28, 2020 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants