Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material-expeirmental/mdc-list): add support for focus/hover states and ripples #19168

Merged
merged 5 commits into from
May 7, 2020
Merged

feat(material-expeirmental/mdc-list): add support for focus/hover states and ripples #19168

merged 5 commits into from
May 7, 2020

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Apr 24, 2020
@mmalerba mmalerba requested a review from jelbourn April 24, 2020 20:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2020
crisbeto
crisbeto approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the lgtm label Apr 28, 2020
@mmalerba mmalerba mentioned this pull request Apr 28, 2020
Merged
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 29, 2020
@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label May 7, 2020
@mmalerba
Copy link
Contributor Author

mmalerba commented May 7, 2020

addressed feedback, PTAL

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 7, 2020
jelbourn
jelbourn approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit d3c00c3 into angular:master May 7, 2020
jelbourn pushed a commit that referenced this pull request May 7, 2020
@mmalerba @jelbourn
feat(material-expeirmental/mdc-list): add support for focus/hover sta…
9f3bba3 
…tes and ripples (#19168)

* feat(material-expeirmental/mdc-list): add support for focus/hover states
and ripples

* add state styles

* fix lint

* address feedback

* address feedback
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @googlebot