-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-list): properly render leading and trailing icons on list items #19201
Conversation
d2fc2a3
to
1c60bbb
Compare
This is rebased and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ling icons on list items (#19201)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
blocked on #19168
Note: I made some changes to the original list demo in this PR:
mat-list-icon
andmat-list-avatar
were pretty much 2 ways to do the same thing in the old version. In the new version, I'm positioningmat-list-avatar
as the bigger leading icon style, andmat-list-icon
as the smaller leading icon style (MDC supports both, and they call the larger one an "avatar", so this actually aligns well). I've changed the demo for the old version to show usingmat-list-icon
in a similar way.