Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk/testing): remove deprecated protractor harness environment from public API #24304

Merged

Conversation

devversion
Copy link
Member

This commit removes the deprecated protractor harness environment from the
public NPM package. Keeping the code in the repository until it can be removed
internally as well.

BREAKING CHANGE: The deprecated angular/cdk/testing/protractor entry-point has been removed.

@devversion devversion added target: major This PR is targeted for the next major release merge safe labels Jan 28, 2022
@devversion devversion force-pushed the internalize-protractor-harness-env branch from 32eed9b to 6f72a24 Compare January 28, 2022 14:13
@devversion devversion changed the title refactor(cdk/testing): remove deprecated protractor harness environment refactor(cdk/testing): remove deprecated protractor harness environment from public API Jan 28, 2022
@devversion devversion marked this pull request as ready for review January 28, 2022 14:49
@devversion devversion requested review from andrewseguin, mmalerba and a team as code owners January 28, 2022 14:49
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a couple nits.

This commit removes the deprecated protractor harness environment from the
public NPM package.

BREAKING CHANGE: The deprecated `angular/cdk/testing/protractor` entry-point has been removed.
@devversion devversion force-pushed the internalize-protractor-harness-env branch from 6f72a24 to 076d2b8 Compare January 28, 2022 15:40
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2022
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto merged commit 2575b00 into angular:master Jan 28, 2022
@devversion devversion added this to the 14.0.0 milestone Jan 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants