Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk/testing): remove deprecated protractor harness environment from public API #24304

Merged
merged 1 commit into from
Jan 28, 2022
+11 −2
Merged

refactor(cdk/testing): remove deprecated protractor harness environment from public API #24304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/check-entry-point-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ const packagesDir = join(__dirname, '../src');
* Globs that matches directories which should never be considered
* as entry-points.
*/
const excludeGlobs = ['cdk/testing/private', '*/schematics/**'];
const excludeGlobs = [
'cdk/testing/private',
'*/schematics/**',
// The protractor testing entry-point is no longer publicly available,
// but exists in the repository until it can be removed in g3.
'cdk/testing/protractor',
];

/** List of detected entry-points which are not properly configured. */
const nonConfigured = [];
Expand Down
1 change: 0 additions & 1 deletion src/cdk/config.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ CDK_ENTRYPOINTS = [
"text-field",
"tree",
"testing",
"testing/protractor",
"testing/testbed",
"testing/selenium-webdriver",
]
Expand Down
4 changes: 4 additions & 0 deletions src/cdk/testing/protractor/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### No longer publicly available

The protractor harness environment is no longer part of the public API. It was
deprecated in v12 and removed from the API in v14.