fix(material/form-field): make notch sizing more reliable #26028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
force-pushed
the
ff-label
branch
2 times, most recently
from
8bd90f4 to
44c4f85
Compare
mmalerba
added
dev-app preview
mmalerba
added
dev-app preview
|
Deployed dev-app to: https://ng-dev-previews-comp--pr-angular-components-26028-e02f-qfra092t.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
devversion
approved these changes
Nov 19, 2022
crisbeto
reviewed
Nov 20, 2022
Swap out the current logic for determining when to resize the outline gap, for logic based on ResizeObserver. The current logic tries to guess when the size may need to change based on observing the content, checking after fonts load, etc. But using ResizeObserver should catch more cases. Also brings the gap calculation logic outside the NgZone to avoid running unnecessary change detections.
mmalerba
force-pushed
the
ff-label
branch
5 times, most recently
from
5e81684 to
b4870f9
Compare
|
This is ready for another look |
crisbeto
reviewed
Nov 23, 2022
|
ready for review again |
angular-robot
bot
added
the
area: build & ci
mmalerba
added
target: minor
This was referenced May 24, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap out the current logic for determining when to resize the outline
gap, for logic based on ResizeObserver. The current logic tries to guess
when the size may need to change based on observing the content,
checking after fonts load, etc. But using ResizeObserver should catch
more cases.
Also brings the gap calculation logic outside the NgZone to avoid
running unnecessary change detections.
Fixes #15027
Fixes #14336