Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): mat-option sets aria-selected="false" #26673

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(material/core): mat-option sets aria-selected="false" #26673

merged 1 commit into from
Mar 7, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 21, 2023

For mat-option, set aria-selected="false" on deselected options. Confirms with WAI ARIA Listbox authoring practices guide, which says to always include aria-selected attribute on listbox options that can be selected. Fix issue where VoiceOver reads every option as "selected" (21491).

Fix #21491

@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release area: material/autocomplete area: material/core area: material/select dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Feb 21, 2023
@zarend zarend force-pushed the option-aria-selected branch from f58d8dd to d436d1e Compare February 21, 2023 21:16
@zarend
fix(material/core): mat-option sets aria-selected="false"
2914d81 
For mat-option, set `aria-selected="false"` on deselected options.
Confirms with [WAI ARIA Listbox authoring practices
guide](https://www.w3.org/WAI/ARIA/apg/patterns/listbox/), which says to
always include aria-selected attribute on listbox options that can be
selected. Fix issue where VoiceOver reads every option as "selected"
(21491).

Fix angular#21491
@zarend zarend force-pushed the option-aria-selected branch from d436d1e to 2914d81 Compare February 21, 2023 21:31
@zarend zarend marked this pull request as ready for review February 21, 2023 21:52
@zarend
Copy link
Contributor Author

zarend commented Feb 21, 2023

Hello folks, this PR is ready for review 👀 .

@crisbeto
Copy link
Member

We got a similar PR a couple of days ago that ended up being closed (#26661), because the previous approach was intentional to reduce the amount of noise for some screen reader users.

@zarend
Copy link
Contributor Author

zarend commented Feb 22, 2023 •
edited
Loading

Yes, I remember when researching this that we used to omit aria-selected="false" to reduce the noise screen readers produce, but that turned out to be in-correct because always setting aria-selected has better compatibility with Assistive Technology and aligns with WAI ARIA guide best practices.. That's why we changed chips and list to always provide aria-selected if an option is selectable.

There is no a11y requirement that says we need to omit aria-selected to reduce noise. We don't want to dictate the behavior that Assistive Technology does because that can lead to unintended effects. Omitting aria-selected is problematic because some screen readers, such as ChromeVox choose to announce options that are not-selected, but not say anything for options that are selected. That means that it's not discernable to users which option is selected if we don't set aria-selected="false" on not selected options.

@zarend zarend requested a review from mmalerba February 22, 2023 18:26
mmalerba
mmalerba approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Feb 23, 2023
@angular-robot angular-robot bot merged commit 4c8f505 into angular:main Mar 7, 2023
angular-robot bot pushed a commit that referenced this pull request Mar 7, 2023
@zarend
fix(material/core): mat-option sets aria-selected="false" (#26673)
1bf2fc2 
For mat-option, set `aria-selected="false"` on deselected options.
Confirms with [WAI ARIA Listbox authoring practices
guide](https://www.w3.org/WAI/ARIA/apg/patterns/listbox/), which says to
always include aria-selected attribute on listbox options that can be
selected. Fix issue where VoiceOver reads every option as "selected"
(21491).

Fix #21491

(cherry picked from commit 4c8f505)
@gregmagolan gregmagolan mentioned this pull request Mar 8, 2023
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 30, 2023
Update angularmaterial monorepo to v15.2.5 (#1813)
365ce55 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.1/15.2.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.1/15.2.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1525-metal-plumber-2023-03-29)

[Compare Source](angular/components@15.2.4...15.2.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [4ec3abd723](angular/components@4ec3abd) | fix | **overlay:** don't close if scroll is coming from inside overlay ([#&#8203;26840](angular/components#26840)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [600d40eb24](angular/components@600d40e) | fix | **datepicker:** remove div as a child of button ([#&#8203;26838](angular/components#26838)) |

#### Special Thanks

Kristiyan Kostadinov and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1524-brimstone-bank-2023-03-23)

[Compare Source](angular/components@15.2.3...15.2.4)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [580fbf500](angular/components@580fbf5) | fix | **core:** apply strong focus styles to selected option ([#&#8203;26811](angular/components#26811)) |
| [1ba5ade41](angular/components@1ba5ade) | fix | **datepicker:** date range input not marked as required when using reactive forms ([#&#8203;26749](angular/components#26749)) |
| [acc7d8148](angular/components@acc7d81) | fix | **tooltip:** only expand hover area on side closest to trigger ([#&#8203;26786](angular/components#26786)) |

#### Special Thanks

Kristiyan Kostadinov, Wagner Maciel and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1523-aluminum-statue-2023-03-16)

[Compare Source](angular/components@15.2.2...15.2.3)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [7dfcf8ff3](angular/components@7dfcf8f) | fix | **checkbox:** fix ARIA semantics and use native DOM properties ([#&#8203;26710](angular/components#26710)) |
| [40d38889c](angular/components@40d3888) | fix | **chips:** chip label appearing above sticky columns ([#&#8203;26794](angular/components#26794)) |
| [b846d1e05](angular/components@b846d1e) | fix | **chips:** don't prevent default mousedown action ([#&#8203;26765](angular/components#26765)) |
| [501d73e5b](angular/components@501d73e) | fix | **chips:** styling not cleared on basic chips in listbox and grid ([#&#8203;26771](angular/components#26771)) |
| [06ed54c25](angular/components@06ed54c) | fix | **tabs:** update MatTab \_scrollToLabel function to always display a label from its start ([#&#8203;26736](angular/components#26736)) ([#&#8203;26737](angular/components#26737)) |

#### Special Thanks

Boyi Li, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1522-topaz-toast-2023-03-08)

[Compare Source](angular/components@15.2.1...15.2.2)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [e7612c747](angular/components@e7612c7) | fix | **chips:** unable to shift + tab out of a chip set ([#&#8203;26727](angular/components#26727)) |
| [1bf2fc2e1](angular/components@1bf2fc2) | fix | **core:** mat-option sets aria-selected="false" ([#&#8203;26673](angular/components#26673)) |
| [9473b1688](angular/components@9473b16) | fix | **datepicker:** resolve server-side rendering error ([#&#8203;26742](angular/components#26742)) |
| [99dac0835](angular/components@99dac08) | fix | **paginator:** opt-out of single-selection indicator ([#&#8203;26746](angular/components#26746)) |
| [ec824f1f7](angular/components@ec824f1) | fix | **snack-bar:** live region not working when modal is open ([#&#8203;26725](angular/components#26725)) |

##### cdk-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [e1c8fe85b](angular/components@e1c8fe8) | fix | **scrolling:** throw error rather than string ([#&#8203;26736](angular/components#26736)) |

#### Special Thanks

Kristiyan Kostadinov, RuoJia123 and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM1LjI0LjYifQ==-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1813
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/autocomplete area: material/core area: material/select dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VoiceOver reads out "selected" after each mat-option inside mat-select
3 participants
@zarend @crisbeto @mmalerba