Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/snack-bar): live region not working when modal is open #26725

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix(material/snack-bar): live region not working when modal is open #26725

merged 1 commit into from
Mar 6, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 4, 2023

Implements a workaround to the issue where some browsers don't expose live elements to the accessibility tree if there's an aria-modal on the page.

Fixes #26708.

@crisbeto
fix(material/snack-bar): live region not working when modal is open
b0f7428 
Implements a workaround to the issue where some browsers don't expose live elements to the accessibility tree if there's an `aria-modal` on the page.

Fixes angular#26708.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Mar 4, 2023
devversion
devversion approved these changes Mar 4, 2023
View reviewed changes
src/material/snack-bar/snack-bar-container.ts
'body > .cdk-overlay-container [aria-modal="true"]',
);

for (let i = 0; i < modals.length; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could use for (const modal of modals)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work, because querySelectorAll returns a NodeList.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A node list is iterable, so it should work: https://developer.mozilla.org/en-US/docs/Web/API/NodeList

But no need to follow-up. As said, a nit.

src/material/snack-bar/snack-bar-container.ts
const ariaOwns = modal.getAttribute('aria-owns');

if (ariaOwns) {
const newValue = ariaOwns.replace(this._liveElementId, '').trim();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if it would be in the middle of other ids? e.g. aria-owns="existing <snackbar> some-other-added"? I guess that is very unlikely to ever happen but want to see what you think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be fine since it would just leave a whitespace which the browser is going to ignore.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2023
@crisbeto crisbeto merged commit 5ea4ca5 into angular:main Mar 6, 2023
crisbeto added a commit that referenced this pull request Mar 6, 2023
@crisbeto
fix(material/snack-bar): live region not working when modal is open (#…
ec824f1 
…26725)

Implements a workaround to the issue where some browsers don't expose live elements to the accessibility tree if there's an `aria-modal` on the page.

Fixes #26708.

(cherry picked from commit 5ea4ca5)
@gregmagolan gregmagolan mentioned this pull request Mar 8, 2023
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 30, 2023
Update angularmaterial monorepo to v15.2.5 (#1813)
365ce55 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.1/15.2.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.1/15.2.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1525-metal-plumber-2023-03-29)

[Compare Source](angular/components@15.2.4...15.2.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [4ec3abd723](angular/components@4ec3abd) | fix | **overlay:** don't close if scroll is coming from inside overlay ([#&#8203;26840](angular/components#26840)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [600d40eb24](angular/components@600d40e) | fix | **datepicker:** remove div as a child of button ([#&#8203;26838](angular/components#26838)) |

#### Special Thanks

Kristiyan Kostadinov and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1524-brimstone-bank-2023-03-23)

[Compare Source](angular/components@15.2.3...15.2.4)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [580fbf500](angular/components@580fbf5) | fix | **core:** apply strong focus styles to selected option ([#&#8203;26811](angular/components#26811)) |
| [1ba5ade41](angular/components@1ba5ade) | fix | **datepicker:** date range input not marked as required when using reactive forms ([#&#8203;26749](angular/components#26749)) |
| [acc7d8148](angular/components@acc7d81) | fix | **tooltip:** only expand hover area on side closest to trigger ([#&#8203;26786](angular/components#26786)) |

#### Special Thanks

Kristiyan Kostadinov, Wagner Maciel and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1523-aluminum-statue-2023-03-16)

[Compare Source](angular/components@15.2.2...15.2.3)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [7dfcf8ff3](angular/components@7dfcf8f) | fix | **checkbox:** fix ARIA semantics and use native DOM properties ([#&#8203;26710](angular/components#26710)) |
| [40d38889c](angular/components@40d3888) | fix | **chips:** chip label appearing above sticky columns ([#&#8203;26794](angular/components#26794)) |
| [b846d1e05](angular/components@b846d1e) | fix | **chips:** don't prevent default mousedown action ([#&#8203;26765](angular/components#26765)) |
| [501d73e5b](angular/components@501d73e) | fix | **chips:** styling not cleared on basic chips in listbox and grid ([#&#8203;26771](angular/components#26771)) |
| [06ed54c25](angular/components@06ed54c) | fix | **tabs:** update MatTab \_scrollToLabel function to always display a label from its start ([#&#8203;26736](angular/components#26736)) ([#&#8203;26737](angular/components#26737)) |

#### Special Thanks

Boyi Li, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1522-topaz-toast-2023-03-08)

[Compare Source](angular/components@15.2.1...15.2.2)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [e7612c747](angular/components@e7612c7) | fix | **chips:** unable to shift + tab out of a chip set ([#&#8203;26727](angular/components#26727)) |
| [1bf2fc2e1](angular/components@1bf2fc2) | fix | **core:** mat-option sets aria-selected="false" ([#&#8203;26673](angular/components#26673)) |
| [9473b1688](angular/components@9473b16) | fix | **datepicker:** resolve server-side rendering error ([#&#8203;26742](angular/components#26742)) |
| [99dac0835](angular/components@99dac08) | fix | **paginator:** opt-out of single-selection indicator ([#&#8203;26746](angular/components#26746)) |
| [ec824f1f7](angular/components@ec824f1) | fix | **snack-bar:** live region not working when modal is open ([#&#8203;26725](angular/components#26725)) |

##### cdk-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [e1c8fe85b](angular/components@e1c8fe8) | fix | **scrolling:** throw error rather than string ([#&#8203;26736](angular/components#26736)) |

#### Special Thanks

Kristiyan Kostadinov, RuoJia123 and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM1LjI0LjYifQ==-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1813
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(dialog/snackbar): a11y - Snackbar contents do not vocalize while dialog is open
2 participants
@crisbeto @devversion