chore: fix gulp-utils color issue #8030
Merged
+737
−322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
chore/fix-gulp-utils-types
branch
from
35d591e to
323d923
Compare
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
chore/fix-gulp-utils-types
branch
from
323d923 to
386556f
Compare
devversion
force-pushed
the
chore/fix-gulp-utils-types
branch
from
386556f to
bdbcd9c
Compare
With (DefinitelyTyped angular#21004) the typings for @gulp-utils are declaring `chalk` as dependency of the types. This causes a conflict with the types from chalk and gulp fails everywhere in the CI. (DefinitelyTyped/DefinitelyTyped#21004) A possible solution would be locking the version of the gulp-util types to the working version `3.0.31`. As `gulp-utils` is only used in one place right now, we are just remove the `gulp-utils` import and just use `console.log` as everywhere else.
devversion
force-pushed
the
chore/fix-gulp-utils-types
branch
from
bdbcd9c to
1372dad
Compare
devversion
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With (DefinitelyTyped #21004) the typings for @gulp-utils are declaring
chalkas dependency of the types. This causes a conflict with the types from chalk and gulp fails everywhere in the CI. (DefinitelyTyped/DefinitelyTyped#21004)A possible solution would be locking the version of the gulp-util types to the working version
3.0.31.As
gulp-utilsis only used in one place right now, we are just remove thegulp-utilsimport and just useconsole.logas everywhere else.