Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular 5 support #6018

Merged
merged 1 commit into from
Nov 1, 2017
Merged

feat: angular 5 support #6018

merged 1 commit into from
Nov 1, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 25, 2017

Bumps to Angular 5.0.0 and sorts out the various issues.

@crisbeto crisbeto added the in progress This issue is currently in progress label Jul 25, 2017
@crisbeto crisbeto self-assigned this Jul 25, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2017
@crisbeto crisbeto requested a review from amcdnl as a code owner August 21, 2017 20:38
@crisbeto crisbeto force-pushed the ng-5 branch 2 times, most recently from 19379b3 to 6174b87 Compare September 9, 2017 16:06
@crisbeto crisbeto added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 14, 2017
@willshowell willshowell mentioned this pull request Oct 17, 2017
@crisbeto crisbeto force-pushed the ng-5 branch 4 times, most recently from d4b8bff to f32f39d Compare October 18, 2017 16:59
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 18, 2017
Fixes a server-side rendering error with the datepicker toggle in Angular 5. This is backported from angular#6018.

Fixes angular#7866.
@crisbeto
Copy link
Member Author

Ready to go @jelbourn. Includes some of @devversion's changes from #8030.

@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Oct 25, 2017
@crisbeto crisbeto changed the title wip: angular 5 support feat: angular 5 support Oct 25, 2017
@crisbeto crisbeto force-pushed the ng-5 branch 2 times, most recently from 2922b40 to 935f3b8 Compare October 26, 2017 20:12
@avril-verhaeghen
Copy link

Hi, any news about this PR? We want to migrate our project van MaterialJS to Angular Material2. For now we're still on 4.4.3 but are going to update to v5. Would be great if we could do both at the same time

@icjking
Copy link

icjking commented Nov 3, 2017

What's the problem with that? thanks

ERROR { Error: Uncaught (in promise): NAMESPACE_ERR: NAMESPACE_ERR (14): the operation is not allowed by Namespaces in XML
NAMESPACE_ERR: NAMESPACE_ERR (14): the operation is not allowed by Namespaces in XML
at Object.exports.NamespaceError (/Users/wangchengjun/www/yooli/mock/angular-mock/node_modules/domino/lib/utils.js:28:45)
at SVGSVGElement.setAttribute (/Users/wangchengjun/www/yooli/mock/angular-mock/node_modules/domino/lib/Element.js:422:50)
at t.setAttribute (/Users/wangchengjun/www/yooli/mock/angular-mock/dist/server.js:128:10526)
at t.e.setAttribute (/Users/wangchengjun/www/yooli/mock/angular-mock/dist/server.js:236:11870)
at e.setAttribute (/Users/wangchengjun/www/yooli/mock/angular-mock/dist/server.js:278:24978)

@CaerusKaru
Copy link
Member

@iTwangcj Are you on the latest version (nightly builds) of Material? If you are and are still having this issue, please open an issue documenting this (or we could reopen #7866).

@icjking
Copy link

icjking commented Nov 6, 2017

Thank you @CaerusKaru @willshowell
I just found the problem two days ago, and I built a new angular5-demo(cli 1.5.0 automatically created).
You need to turn on the server rendering and app.component.html to add the following code:

app.component.html

<router-outlet></router-outlet>

<!-- The problem is here! -->
<div class="fmape">
    <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1440 810">
        <path fill="#efefee" d="M592.66 0c-15 64.092-30.7 125.285-46.598 183.777C634.056 325.56 748.348 550.932 819.642 809.5h419.672C1184.518 593.727 1083.124 290.064 902.637 0H592.66z"></path>
        <path fill="#f6f6f6" d="M545.962 183.777c-53.796 196.576-111.592 361.156-163.49 490.74 11.7 44.494 22.8 89.49 33.1 134.883h404.07c-71.294-258.468-185.586-483.84-273.68-625.623z"></path>
        <path fill="#f7f7f7" d="M153.89 0c74.094 180.678 161.088 417.448 228.483 674.517C449.67 506.337 527.063 279.465 592.56 0H153.89z"></path>
        <path fill="#fbfbfc" d="M153.89 0H0v809.5h415.57C345.477 500.938 240.884 211.874 153.89 0z"></path>
        <path fill="#ebebec" d="M1144.22 501.538c52.596-134.583 101.492-290.964 134.09-463.343 1.2-6.1 2.3-12.298 3.4-18.497 0-.2.1-.4.1-.6 1.1-6.3 2.3-12.7 3.4-19.098H902.536c105.293 169.28 183.688 343.158 241.684 501.638v-.1z"></path>
        <path fill="#e1e1e1" d="M1285.31 0c-2.2 12.798-4.5 25.597-6.9 38.195C1321.507 86.39 1379.603 158.98 1440 257.168V0h-154.69z"></path>
        <path fill="#e7e7e7" d="M1278.31,38.196C1245.81,209.874 1197.22,365.556 1144.82,499.838L1144.82,503.638C1185.82,615.924 1216.41,720.211 1239.11,809.6L1439.7,810L1439.7,256.768C1379.4,158.78 1321.41,86.288 1278.31,38.195L1278.31,38.196z"></path>
    </svg>
</div>

Run: NPM run start problem will appear. Thank you for offering solutions

This is an error in Angular core, not Material. You can work around it by removing the xmlns attribute.
Thanks,Problem solving。

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants