-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlay): flexible overlay with push not handling scroll offset and position locking #11628
fix(overlay): flexible overlay with push not handling scroll offset and position locking #11628
Conversation
Caretaker note: this caused an issue with menu positioning in Firebase last attempt; we need to debug that before syncing |
Just reported an issue which is also fixed by this PR: #11763 |
Actually i'm not sure if #11763 is fixed by this PR. That is specifically related to the origin element being fixed/has a position: fixed parent element. |
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
…nd position locking * Fixes the position of flexible overlays with pushing enabled being thrown off once the user starts scrolling. * Fixes flexible overlays with pushing not handling locked positioning. With these changes locked overlays will only be pushed when they're opened, whereas non-locked overlays will stay in the viewport, even when the user scrolls down. * Fixes a potential issue due to a couple of variables being initialized together where one is set to zero and the other one is undefined. Fixes angular#11365.
36c89f0
to
3b6ef19
Compare
…nd position locking (#11628)
…nd position locking (#11628)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a resubmit of #11421.
Fixes #11365.