Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delta Abbreviation: ∆ instead of ▲ #327

Closed
0xferit opened this issue Nov 24, 2017 · 2 comments
Closed

Delta Abbreviation: ∆ instead of ▲ #327

0xferit opened this issue Nov 24, 2017 · 2 comments
Labels
good first issue help wanted

Comments

@0xferit
Copy link
Contributor

0xferit commented Nov 24, 2017

We decided in #324, that symbol for delta abbreviation to be ∆. For consistency, we should replace every delta symbol with ∆ instead of ▲ (or whatever currently it is).
@angularsen
Copy link
Owner

To avoid creating a breaking change, the old unit abbreviation should stay, but we add the new abbreviation before it in the list so that it takes presedence in ToString(). We can then add to our #180 wishlist for future removal in a major version bump.

@jnyrup jnyrup mentioned this issue Nov 25, 2017
Merged
@angularsen angularsen mentioned this issue Dec 10, 2017
Merged
dutts added a commit to dutts/UnitsNet that referenced this issue Dec 10, 2017
@dutts
Changed ▲to ∆ as per angularsen#327 and angularsen#328
acb2066
angularsen pushed a commit that referenced this issue Dec 10, 2017
@dutts @angularsen
Removed Delta suffix of TemperatureDelta units (#339)
431527d 
Fixes #331

* Removed Delta suffix of TemperatureDelta units

Fixed generate-code.bat to allow spaces in script path.

* Fixed breaking tests caused by enums no longer matching by value with the addition of new non-"Delta" units

* Changed BaseUnit from KelvinDelta to Kelvin and updated test code

* Changed ▲to ∆ as per #327 and #328
@angularsen
Copy link
Owner

Fixed in #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angularsen @0xferit