Removed Delta suffix of TemperatureDelta units (Fixes #331). #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed generate-code.bat to allow spaces in script path.
angularsen
requested changes
Dec 10, 2017
| @@ -3,9 +3,106 @@ | |||
| "BaseUnit": "KelvinDelta", | |||
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "▲K" ] |
| @@ -90,6 +193,7 @@ | |||
| { | |||
| "SingularName": "DegreeRoemerDelta", | |||
| "PluralName": "DegreesRoemerDelta", | |||
| "ObsoleteText": "Deprecated due to github issue #180, please use DegreeRoemer instead", | |||
| @@ -1,3 +1,3 @@ | |||
| @echo off | |||
| SET scriptdir=%~dp0 | |||
| powershell -ExecutionPolicy Bypass -NoProfile -File %scriptdir%UnitsNet\Scripts\GenerateUnits.ps1 | |||
| powershell -ExecutionPolicy Bypass -NoProfile -File "%scriptdir%UnitsNet\Scripts\GenerateUnits.ps1" | |||
| protected override double DegreesRankineInOneKelvinDelta => 1.8; | ||
| protected override double DegreesReaumurInOneKelvinDelta => 0.8; | ||
| protected override double DegreesRoemerInOneKelvinDelta => 21 / 40d; | ||
| protected override double KelvinsInOneKelvinDelta => 1; |
There was a problem hiding this comment.
When changing base unit to Kelvin as commented below and regenerating the code, then this test code must be updated too.
… the addition of new non-"Delta" units
|
Will address the comments, cheers |
angularsen
approved these changes
Dec 10, 2017
| @@ -94,7 +95,7 @@ public void MultiplyByTemperatureDeltaEqualsTemperature(TemperatureUnit unit, in | |||
| public void TemperatureDeltaPlusTemperatureEqualsTemperature(TemperatureUnit unit, int deltaVal, int temperatureVal, string expected) | |||
| { | |||
| Temperature temperature = Temperature.From(temperatureVal, unit); | |||
| TemperatureDelta delta = TemperatureDelta.From(deltaVal, (TemperatureDeltaUnit) unit); | |||
| TemperatureDelta delta = TemperatureDelta.From(deltaVal, (TemperatureDeltaUnit)Enum.Parse(typeof(TemperatureDeltaUnit), unit.ToString())); | |||
|
Nuget 3.84 on its way out |
|
Awesome! I’ll get cracking on the other issue when I get a second.
… On 10 Dec 2017, at 19:56, Andreas Gullberg Larsen ***@***.***> wrote:
Nuget 3.84 on its way out
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed generate-code.bat to allow spaces in script path.