Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rds_instance* modules and tests #1011

Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
0b72cdc
Initial commit
jillr Mar 2, 2020
1503b42
migration test cleanup
jillr Mar 3, 2020
af8bfc7
Rename collection (#12)
jillr Mar 25, 2020
4f97601
Remove METADATA and cleanup galaxy.yml (#70)
jillr May 19, 2020
afdf23f
Collections related fixes for CI (#96)
jillr Jun 16, 2020
24e1488
Update Examples with FQCN (#67)
Akasurde Jun 16, 2020
f2cc00d
Update module_utils paths to remove aws subdir (#23)
flowerysong Jun 16, 2020
03fd3ae
Update docs (#99)
jillr Jun 17, 2020
e13aab8
Docs: sanity fixes (#133)
Akasurde Jul 15, 2020
522d5b6
Updated rds_instance backup_retention_period parameter docs (#183)
JeanMarcSaad Aug 12, 2020
5de326a
Type conversion issue for creating read replicas (#229)
tombenninger Sep 25, 2020
8e697bb
rds_instance: Set no_log=False on force_update_password
tremble Sep 24, 2020
e26425d
Bulk migration to fail_json_aws (#361)
tremble Jan 27, 2021
e52d600
Cleanup - use is_boto3_error_(message|code) (#268)
tremble Feb 5, 2021
36a6fde
Move tests to using module_defaults (#368)
tremble Feb 10, 2021
c57b789
Add comments to the disabled/unsupported integration test aliase file…
tremble Feb 13, 2021
501ca15
dict Tags to list on restore_db_instance_from_db_snapshot
vorotech Feb 15, 2021
04e134b
rds_instance - test fixups (#515)
tremble Apr 6, 2021
10afc3b
rds_instance: Add purge_security_groups (#500)
alinabuzachis Apr 7, 2021
b979f38
rds_instance - fix idempotency when using non-lowercase for preferred…
tremble Apr 9, 2021
a4daac8
Run RDS tests in parallel (Databases are *slow*)
tremble Apr 7, 2021
1548835
idempotency with read_replica seems to be broken
tremble Apr 8, 2021
5be9104
Update the default module requirements from python 2.6/boto to python…
tremble May 6, 2021
0423ad2
Remove RDS invalid credentials tests - they're tested in amazon.aws m…
tremble Jul 31, 2021
fa3c59c
Remove code testing for unsupported versions of boto3/botocore
tremble Aug 6, 2021
97c3adf
use a generator rather than list comprehension when using any()/all()…
tremble Aug 12, 2021
beb6be3
Undocumented IOPS return
doticatto Sep 2, 2021
6428139
Rds enhanced monitoring bug fix (#747)
marknet15 Oct 22, 2021
21a5746
Rename rds_snapshot to rds_instance_snapshot (#783)
alinabuzachis Oct 28, 2021
2a9bc32
Remove deprecated "facts" aliases (#814)
jillr Dec 2, 2021
bf66d00
Remove deprecated Modules (#839)
markuman Jan 5, 2022
2aa3c30
Fix IOPs io1 DB instance updates and integration tests also (#878)
marknet15 Feb 4, 2022
b84cb2b
Various integration test fixes (#984)
tremble Mar 14, 2022
945f160
Fix documentation about force_update_password in rds_instance module …
stefanhorning Mar 15, 2022
ea5258f
rds_instance - add valid choices for engine type (#1034)
jatorcasso Mar 30, 2022
47a7799
rds_instance - fix check_mode and idempotence bugs and support adding…
jatorcasso Apr 12, 2022
66acf49
For consistency - add empty dependencies file to targets with no curr…
tremble Apr 22, 2022
1b2a842
rds_instance - add deletion_protection param (#1105)
jatorcasso May 9, 2022
3c7d16b
Update rds_instance_snaphot to use handlers defined in rds.py (#789)
alinabuzachis May 9, 2022
7654a64
rds_instance - add snapshot tests, update docs, refactor tests (#1081)
jatorcasso May 24, 2022
18496bf
rds_instance_snapshot - add copy snapshot functionality (#1078)
jatorcasso May 25, 2022
edc557b
Tagging fragment - Move simplest cases over to the docs fragment. (#1…
tremble Jun 1, 2022
9da0577
Tagging fragment - Move simplest cases over to the docs fragment. (#1…
tremble Jun 2, 2022
6fa3ea2
fix sporadic test failure in processor features (#1196)
jatorcasso Jun 3, 2022
74b19b7
Add AWSRetry.jittered_backoff to rds_instance_info (#1026)
kteague-tasktop Jun 4, 2022
25473db
Flag rds_instance_snapshot tests as slow (#1397)
tremble Aug 8, 2022
da7e96b
adjust booleans (#1420)
markuman Aug 26, 2022
1101d55
Update runtime
alinabuzachis Sep 16, 2022
31768aa
Update FQDN
alinabuzachis Sep 16, 2022
b0582ad
Remove collection reference inside the tests
alinabuzachis Sep 16, 2022
2a8897c
Add changelog fragment
alinabuzachis Sep 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
idempotency with read_replica seems to be broken
  • Loading branch information
tremble authored and goneri committed Sep 21, 2022
commit 1548835e27ff4003ed65f05fe7e7ba3a536ea2e5
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,10 @@
Created_by: Ansible rds_instance tests
register: result

- assert:
that:
- not result.changed
## XXX Bug
# - assert:
# that:
# - not result.changed

- name: Test idempotence with read_replica=True
rds_instance:
Expand Down Expand Up @@ -123,9 +124,10 @@
region: "{{ region_dest }}"
register: result

- assert:
that:
- not result.changed
## XXX Bug
#- assert:
# that:
# - not result.changed

always:

Expand Down