Migrate rds_instance* modules and tests #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
@alinabuzachis This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
needs_info
alinabuzachis
changed the title
jillr
approved these changes
Sep 15, 2022
alinabuzachis
force-pushed
the
promote_rds_instance
branch
from
0e496ae to
95c91b7
Compare
gravesm
approved these changes
Sep 16, 2022
|
regate |
abikouo
approved these changes
Sep 21, 2022
|
regate |
goneri
added
mergeit
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
regate |
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
Remove deprecated "facts" aliases SUMMARY Modules named "facts.py" that do not return ansible_facts were renamed to "info.py" in 2.9. Remove these aliases now that the deprecation period is over. This PR should be included in 3.0.0 of the collection. ISSUE TYPE Bugfix Pull Request COMPONENT NAME *_facts.py Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@68aaa70
Remove deprecated Modules SUMMARY Remove deprecated modules for 3.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.iam community.aws.rds Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2096b7f
…collections#878) Fix IOPs io1 DB instance updates and integration tests also SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally. Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@45e79ed
Various integration test fixes SUMMARY Updates the version of Python used by lambda in the lambda_alias, lambda_policy and aws_secret integration tests Updates the version of NodeJS used by the lambda in the lamba integration tests Adds a retry to the s3_bucket_notification tests, permissions are sometimes a little slow to update Cleans up Snapshots from rds_instance integration tests Disables broken WAFv2 integration test (ansible-collections#985) Fixes: ansible-collections#976 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret lambda lambda_alias lambda_policy rds_policy s3_bucket_notification wafv2 ADDITIONAL INFORMATION Amazon appear to have dropped support for creating Python2.7 lambdas: botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions. Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c5e4640
…nsible-collections#957) Fix documentation about force_update_password in rds_instance module SUMMARY Wrong name used in docs. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/rds_instance.py Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ab58075
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
…/removing iam roles (ansible-collections#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes ansible-collections#464 Fixes ansible-collections#1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c403552
…ent meta data (ansible-collections#1090) For consistency - add empty dependencies file to targets with no current meta data SUMMARY For consistency - add empty dependencies file to targets with no current meta data ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9638580
rds_instance - add deletion_protection param Depends-On: ansible-collections#1116 SUMMARY Fixes ansible-collections#922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@77cb097
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
…le-collections#1081) rds_instance - add snapshot tests, update docs, refactor tests Depends-On: ansible-collections#776 Depends-On: ansible-collections#1105 SUMMARY add snapshot tests to test restoring db from snapshot and fix bugs associated fix some typos in documentation and remove duplicate parameter (added as alias so no breaking change) remove unused IAM role in tests and add some missing cleanups ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION this module had both db_snapshot_identifier and snapshot_identifier as separate params, with the latter being required to restore from snapshot, resulting in some parameter missing errors. moving snapshot_identifier as an alias of db_snapshot_identifier fixes this issue. Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Sloane Hertel <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5d5bca9
…ections#1078) rds_instance_snapshot - add copy snapshot functionality Depends-On: ansible-collections#776 Depends-On: ansible-collections#1116 SUMMARY Add support for copying a snapshot Fixes ansible-collections#210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d04ab42
…sible-collections#1182) Tagging fragment - Move simplest cases over to the docs fragment. Depends-On: ansible-collections#844 SUMMARY Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME changelogs/fragments/1182-tagging.yml plugins/modules/aws_glue_job.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_secret.py plugins/modules/aws_step_functions_state_machine.py plugins/modules/dynamodb_table.py plugins/modules/ec2_eip.py plugins/modules/ec2_transit_gateway_vpc_attachment.py plugins/modules/ec2_vpc_peer.py plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py plugins/modules/iam_role.py plugins/modules/iam_user.py plugins/modules/networkfirewall.py plugins/modules/networkfirewall_policy.py plugins/modules/networkfirewall_rule_group.py plugins/modules/rds_cluster.py plugins/modules/rds_instance.py plugins/modules/rds_instance_snapshot.py plugins/modules/rds_option_group.py plugins/modules/rds_subnet_group.py plugins/modules/redshift.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b11ffae
…sible-collections#1200) Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. SUMMARY The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off. ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot ADDITIONAL INFORMATION The change itself was approved on ansible-collections#1182 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9ca5540
…1196) rds_instance - fix sporadic test failure in processor features SUMMARY Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION when processor features are applied and not pending: 2022-06-01 22:24:33.960215 | controller | "pending_modified_values": {}, 2022-06-01 22:24:33.960221 | controller | "performance_insights_enabled": false, 2022-06-01 22:24:33.960227 | controller | "preferred_backup_window": "06:49-07:19", 2022-06-01 22:24:33.960234 | controller | "preferred_maintenance_window": "thu:06:19-thu:06:49", 2022-06-01 22:24:33.960239 | controller | "processor_features": { 2022-06-01 22:24:33.960245 | controller | "coreCount": "4", 2022-06-01 22:24:33.960252 | controller | "threadsPerCore": "2" 2022-06-01 22:24:33.960258 | controller | }, 2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] *************************************************** 2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105 2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => { 2022-06-01 22:24:45.613339 | controller | "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'" 2022-06-01 22:24:45.613347 | controller | } Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@72be46e
…ns#1026) Add AWSRetry.jittered_backoff to rds_instance_info SUMMARY Add AWSRetry.jittered_backoff to the rds_instance_info module. When calling rds_instance_info we have been seeing API rate limit errors from AWS. When calling this module, it usually runs to about 90-150 times in a minute before we get rate limited. Using jittered_backoff should significantly decrease the number of times we see API rate limits here. 02:20:36 An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeDBInstances operation (reached max retries: 4): Rate exceeded 02:20:36 fatal: [polaris -> localhost]: FAILED! => {"boto3_version": "1.20.22", "botocore_version": "1.23.22", "changed": false, "error": {"code": "Throttling", "message": "Rate exceeded", "type": "Sender"}, "msg": "Couldn't get instance information: An error occurred (Throttling) when calling the DescribeDBInstances operation (reached max retries: 4): Rate exceeded", "response_metadata": {"http_headers": {"connection": "close", "content-length": "254", "content-type": "text/xml", "date": "Tue, 15 Mar 2022 09:20:34 GMT", "x-amzn-requestid": "5de8131e-3f59-4b04-af25-5f7083ee09b9"}, "http_status_code": 400, "max_attempts_reached": true, "request_id": "5de8131e-3f59-4b04-af25-5f7083ee09b9", "retry_attempts": 4}} ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance_info ADDITIONAL INFORMATION Decorated rds_instance_info with AWSRetry.jittered_backoff Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6a2793a
Flag rds_instance_snapshot tests as slow SUMMARY rds_instance_snapshot tests are slow, which causes problems when module_util changes in amazon.aws trigger lots of tests to run. ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b81dbe7
adjust booleans: use true/false Depends-On: ansible-collections#1423 SUMMARY ansible-community/community-topics#116 ISSUE TYPE Docs Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cb9716e
goneri
force-pushed
the
promote_rds_instance
branch
from
fa0aa0e to
2a8897c
Compare
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 53s |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Sep 23, 2022
Migrate rds_instance* modules and tests Depends-On: ansible-collections/amazon.aws#1011 Depends-On: #1480 Remove rds_instance* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_instance* modules and tests Depends-On: ansible-collections#1011 Depends-On: ansible-collections#1480 Remove rds_instance* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_instance* modules and tests Depends-On: ansible-collections#1011 Depends-On: ansible-collections#1480 Remove rds_instance* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/zuul-config#443
Migrate rds_instance* modules and tests