Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual backport stable-5] Don't consider prop 'StateTransitionedTimestamp' in change detection (#1440) #1480

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated.

Fixes #1439
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudwatch-metric-alarm
ADDITIONAL INFORMATION
See issue #1439 for additional details.

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

…nsible-collections#1440)

Don't consider prop 'StateTransitionedTimestamp' in change detection

SUMMARY

Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated.

Fixes ansible-collections#1439
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudwatch-metric-alarm
ADDITIONAL INFORMATION
See issue ansible-collections#1439 for additional details.

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7f2b5e70a2de48dcb5b5bf302506fbca

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 12m 47s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-amazon.aws-1 SUCCESS in 11m 54s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/2191b115b9934ebfaa1d2fac01b776c6

✔️ ansible-galaxy-importer SUCCESS in 5m 28s
✔️ build-ansible-collection SUCCESS in 13m 39s
✔️ ansible-test-splitter SUCCESS in 5m 48s
✔️ integration-amazon.aws-1 SUCCESS in 8m 30s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aa6da23 into ansible-collections:stable-5 Apr 26, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Migrate rds_instance* modules and tests

Depends-On: ansible-collections#1011
Depends-On: ansible-collections#1480
Remove rds_instance* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Migrate rds_instance* modules and tests

Depends-On: ansible-collections#1011
Depends-On: ansible-collections#1480
Remove rds_instance* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Update rds_instance* doc links
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Migrate rds_instance* modules and tests

Depends-On: ansible-collections#1011
Depends-On: ansible-collections#1480
Remove rds_instance* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants