More no_log=False to fix sanity tests (#474)

* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

plugins/modules/aws_batch_compute_environment.py

@@ -460,7 +460,7 @@ def main():
         image_id=dict(),
         subnets=dict(type='list', required=True, elements='str'),
         security_group_ids=dict(type='list', required=True, elements='str'),
-        ec2_key_pair=dict(),
+        ec2_key_pair=dict(no_log=False),
         instance_role=dict(required=True),
         tags=dict(type='dict'),
         bid_percentage=dict(type='int'),

plugins/modules/aws_codebuild.py

@@ -378,7 +378,7 @@ def main():
         environment=dict(type='dict'),
         service_role=dict(),
         timeout_in_minutes=dict(type='int', default=60),
-        encryption_key=dict(),
+        encryption_key=dict(no_log=False),
         tags=dict(type='list', elements='dict'),
         vpc_config=dict(type='dict'),
         state=dict(choices=['present', 'absent'], default='present')

plugins/modules/cloudtrail.py

@@ -438,7 +438,7 @@ def main():
         name=dict(default='default'),
         enable_logging=dict(default=True, type='bool'),
         s3_bucket_name=dict(),
-        s3_key_prefix=dict(),
+        s3_key_prefix=dict(no_log=False),
         sns_topic_name=dict(),
         is_multi_region_trail=dict(default=False, type='bool'),
         enable_log_file_validation=dict(type='bool', aliases=['log_file_validation_enabled']),

plugins/modules/dms_endpoint.py

@@ -387,7 +387,7 @@ def main():
         port=dict(type='int'),
         databasename=dict(),
         extraconnectionattributes=dict(),
-        kmskeyid=dict(),
+        kmskeyid=dict(no_log=False),
         tags=dict(type='dict'),
         certificatearn=dict(),
         sslmode=dict(choices=['none', 'require', 'verify-ca', 'verify-full'],

plugins/modules/ec2_vpc_endpoint.py

@@ -352,7 +352,7 @@ def main():
         wait_timeout=dict(type='int', default=320, required=False),
         route_table_ids=dict(type='list', elements='str'),
         vpc_endpoint_id=dict(),
-        client_token=dict(),
+        client_token=dict(no_log=False),
     )
     module = AnsibleAWSModule(
         argument_spec=argument_spec,

plugins/modules/ec2_vpc_nat_gateway.py

@@ -1020,7 +1020,7 @@ def main():
         wait_timeout=dict(type='int', default=320, required=False),
         release_eip=dict(type='bool', default=False),
         nat_gateway_id=dict(type='str'),
-        client_token=dict(type='str'),
+        client_token=dict(type='str', no_log=False),
         tags=dict(required=False, type='dict', aliases=['resource_tags']),
         purge_tags=dict(default=True, type='bool'),
     )

plugins/modules/ecs_service.py

@@ -652,7 +652,7 @@ def main():
         task_definition=dict(required=False, type='str'),
         load_balancers=dict(required=False, default=[], type='list', elements='dict'),
         desired_count=dict(required=False, type='int'),
-        client_token=dict(required=False, default='', type='str'),
+        client_token=dict(required=False, default='', type='str', no_log=False),
         role=dict(required=False, default='', type='str'),
         delay=dict(required=False, type='int', default=10),
         repeat=dict(required=False, type='int', default=10),

plugins/modules/iam.py

@@ -627,7 +627,7 @@ def main():
         access_key_state=dict(default=None, required=False, choices=[
             'active', 'inactive', 'create', 'remove',
             'Active', 'Inactive', 'Create', 'Remove']),
-        access_key_ids=dict(type='list', default=None, required=False, elements='str'),
+        access_key_ids=dict(type='list', default=None, required=False, elements='str', no_log=False),
         key_count=dict(type='int', default=1, required=False),
         name=dict(required=True),
         trust_policy_filepath=dict(default=None, required=False),

plugins/modules/lambda.py

@@ -330,7 +330,7 @@ def main():
         handler=dict(),
         zip_file=dict(aliases=['src']),
         s3_bucket=dict(),
-        s3_key=dict(),
+        s3_key=dict(no_log=False),
         s3_object_version=dict(),
         description=dict(default=''),
         timeout=dict(type='int', default=3),

plugins/modules/lambda_policy.py

@@ -397,7 +397,7 @@ def setup_module_object():
         principal=dict(required=True, ),
         source_arn=dict(),
         source_account=dict(),
-        event_source_token=dict(),
+        event_source_token=dict(no_log=False),
     )
 
     return AnsibleAWSModule(

plugins/modules/s3_website.py

@@ -291,7 +291,7 @@ def main():
         name=dict(type='str', required=True),
         state=dict(type='str', required=True, choices=['present', 'absent']),
         suffix=dict(type='str', required=False, default='index.html'),
-        error_key=dict(type='str', required=False),
+        error_key=dict(type='str', required=False, no_log=False),
         redirect_all_requests=dict(type='str', required=False),
     )
 

plugins/modules/sqs_queue.py

@@ -450,7 +450,7 @@ def main():
         redrive_policy=dict(type='dict'),
         visibility_timeout=dict(type='int', aliases=['default_visibility_timeout']),
         kms_master_key_id=dict(type='str'),
-        kms_data_key_reuse_period_seconds=dict(type='int', aliases=['kms_data_key_reuse_period']),
+        kms_data_key_reuse_period_seconds=dict(type='int', aliases=['kms_data_key_reuse_period'], no_log=False),
         content_based_deduplication=dict(type='bool'),
         tags=dict(type='dict'),
         purge_tags=dict(type='bool', default=False),