Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More no_log=False to fix sanity tests #474

Merged
merged 2 commits into from
Mar 13, 2021
Merged

More no_log=False to fix sanity tests #474

merged 2 commits into from
Mar 13, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Follow-up to ansible-collections/amazon.aws#303 (without that there will be tons of errors for aws_access_key).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_batch_compute_environment
dms_endpoint
ec2_vpc_endpoint
ec2_vpc_nat_gateway
ecs_service
iam
lambda_policy
aws_codebuild
cloudtrail
lambda
s3_website
sqs_queue

@ansibullbot
Copy link

cc @Etherdaemon @Java1Guy @jillr @jonhadfield @jonmer85 @kaczynskid @linuxdynasty @loia @mikedlr @nand0p @pjodouin @ruimoreira @s-hertel @sbj-ss @shepdelacreme @stefanhorning @steynovich @tremble @wimnat @zacblazic
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Mar 13, 2021
tremble
tremble approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • ec2_key_pair - name for an SSH public key
  • encryption_key - KMS CMK (ID)
  • s3_key_prefix - just a folder name
  • kmskeyid - KMS CMK (ID)
  • client_token - an identifier that can be used to tie together multiple changes for idempotency
  • access_key_ids - a list of access Key IDs
  • s3_key - just a folder name
  • event_source_token - An Account ID or ARN
  • error_key - the folder where error pages are found
  • kms_data_key_reuse_period_seconds - just a time

@tremble
Copy link
Contributor

tremble commented Mar 13, 2021

Failed sanity test is because there are more issues covered by #475

@tremble tremble merged commit 67b6d75 into ansible-collections:main Mar 13, 2021
@felixfontein felixfontein deleted the secrets branch March 13, 2021 19:15
@felixfontein
Copy link
Contributor Author

@tremble thanks for reviewing and merging!

danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
@felixfontein @danquixote
More no_log=False to fix sanity tests (ansible-collections#474)
53e6b1e 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@felixfontein
[promoted]More no_log=False to fix sanity tests (ansible-collections#474
6a9fb7d 
)

* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@67b6d75
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@felixfontein
More no_log=False to fix sanity tests (ansible-collections#474)
6e02ef2 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@felixfontein
More no_log=False to fix sanity tests (ansible-collections#474)
2ab7c01 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@felixfontein @danielcotton
More no_log=False to fix sanity tests (ansible-collections#474)
3a7e331 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@felixfontein @alinabuzachis
More no_log=False to fix sanity tests (ansible-collections#474)
f5ec6d2 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@67b6d75
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@felixfontein @jillr
More no_log=False to fix sanity tests (ansible-collections#474)
7f3a941 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@67b6d75
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@lowlydba
Update plugins/modules/ec2_vol.py (ansible-collections#474)
e8df917 
Update plugins/modules/ec2_vol.py

SUMMARY

Fix grammatical error in docs - modify --> modified

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ec2_vol

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
f267b0b 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@67b6d75
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
7be748f 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@67b6d75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @tremble