Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MSK modules #1311

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 5, 2022

SUMMARY

In line with the naming guidelines, drop the aws_ prefix from the MSK modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_msk_cluster.py
plugins/modules/msk_cluster.py
plugins/modules/aws_msk_config.py
plugins/modules/msk_config.py

ADDITIONAL INFORMATION

@tremble tremble requested review from alinabuzachis and markuman July 5, 2022 12:12
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 5, 2022
plugins/modules/msk_config.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 01s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 26s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 46s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 11s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 58s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 54s
✔️ ansible-test-splitter SUCCESS in 3m 11s
✔️ integration-community.aws-1 SUCCESS in 42m 55s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 50s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 10s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 44s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 34s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 48s
✔️ ansible-test-splitter SUCCESS in 3m 24s
✔️ integration-community.aws-1 SUCCESS in 50m 54s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c6936e8 into ansible-collections:main Jul 5, 2022
@tremble tremble deleted the renames/msk branch July 7, 2022 19:22
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ions#1311)

ec2_eni_info - update docs default entry for filters

SUMMARY
Devel is currently reporting a sanity failure:
2023-01-02 21:42:04.487975 | controller | ERROR: plugins/modules/ec2_eni_info.py:0:0: doc-default-does-not-match-spec: Argument 'filters' in argument_spec defines default as ({}) but documentation defines default as (None)

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_eni_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants