Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MSK modules #1311

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ Name | Description
[community.aws.autoscaling_scheduled_action](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.autoscaling_scheduled_action_module.rst)|Create, modify and delete ASG scheduled scaling actions
[community.aws.aws_application_scaling_policy](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_application_scaling_policy_module.rst)|Manage Application Auto Scaling Scaling Policies
[community.aws.aws_inspector_target](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_inspector_target_module.rst)|Create, Update and Delete Amazon Inspector Assessment Targets
[community.aws.aws_msk_cluster](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_msk_cluster_module.rst)|Manage Amazon MSK clusters
[community.aws.aws_msk_config](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_msk_config_module.rst)|Manage Amazon MSK cluster configurations.
[community.aws.aws_region_info](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_region_info_module.rst)|Gather information about AWS regions.
[community.aws.aws_secret](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_secret_module.rst)|Manage secrets stored in AWS Secrets Manager
[community.aws.aws_ssm_parameter_store](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.aws_ssm_parameter_store_module.rst)|Manage key-value pairs in AWS SSM parameter store
Expand Down Expand Up @@ -169,6 +167,8 @@ Name | Description
[community.aws.lambda_info](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.lambda_info_module.rst)|Gathers AWS Lambda function details
[community.aws.lambda_policy](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.lambda_policy_module.rst)|Creates, updates or deletes AWS Lambda policy statements.
[community.aws.lightsail](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.lightsail_module.rst)|Manage instances in AWS Lightsail
[community.aws.msk_cluster](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.msk_cluster_module.rst)|Manage Amazon MSK clusters
[community.aws.msk_config](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.msk_config_module.rst)|Manage Amazon MSK cluster configurations
[community.aws.networkfirewall](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.networkfirewall_module.rst)|manage AWS Network Firewall firewalls
[community.aws.networkfirewall_info](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.networkfirewall_info_module.rst)|describe AWS Network Firewall firewalls
[community.aws.networkfirewall_policy](https://github.com/ansible-collections/community.aws/blob/main/docs/community.aws.networkfirewall_policy_module.rst)|manage AWS Network Firewall policies
Expand Down
3 changes: 3 additions & 0 deletions changelogs/fragments/1311-rename-msk.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
minor_changes:
- aws_msk_cluster - the ``aws_msk_cluster`` module has been renamed to ``msk_cluster``, ``aws_msk_cluster`` remains as an alias (https://github.com/ansible-collections/community.aws/pull/1311).
- aws_msk_config - the ``aws_msk_config`` module has been renamed to ``msk_config``, ``aws_msk_config`` remains as an alias (https://github.com/ansible-collections/community.aws/pull/1311).
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.. _community.aws.aws_msk_cluster_module:
.. _community.aws.msk_cluster_module:


*****************************
community.aws.aws_msk_cluster
*****************************
*************************
community.aws.msk_cluster
*************************

**Manage Amazon MSK clusters**

Expand All @@ -18,6 +18,7 @@ Version added: 2.0.0
Synopsis
--------
- Create, delete and modify Amazon MSK (Managed Streaming for Apache Kafka) clusters.
- Prior to release 5.0.0 this module was called ``community.aws.aws_msk_cluster``. The usage did not change.



Expand Down Expand Up @@ -842,7 +843,6 @@ Parameters
<div>The version of Apache Kafka.</div>
<div>This version should exist in given configuration.</div>
<div>This parameter is required when <em>state=present</em>.</div>
<div>Update operation requires botocore version &gt;= 1.16.19.</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -903,7 +903,7 @@ Examples

# Note: These examples do not set authentication details, see the AWS Guide for details.

- aws_msk_cluster:
- msk_cluster:
name: kafka-cluster
state: present
version: 2.6.1
Expand All @@ -918,7 +918,7 @@ Examples
configuration_arn: arn:aws:kafka:us-east-1:000000000001:configuration/kafka-cluster-configuration/aaaaaaaa-bbbb-4444-3333-ccccccccc-1
configuration_revision: 1

- aws_msk_cluster:
- msk_cluster:
name: kafka-cluster
state: absent

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
.. _community.aws.aws_msk_config_module:
.. _community.aws.msk_config_module:


****************************
community.aws.aws_msk_config
****************************
************************
community.aws.msk_config
************************

**Manage Amazon MSK cluster configurations.**
**Manage Amazon MSK cluster configurations**


Version added: 2.0.0
Expand All @@ -18,6 +18,7 @@ Version added: 2.0.0
Synopsis
--------
- Create, delete and modify Amazon MSK (Managed Streaming for Apache Kafka) cluster configurations.
- Prior to release 5.0.0 this module was called ``community.aws.aws_msk_config``. The usage did not change.



Expand Down Expand Up @@ -315,7 +316,7 @@ Examples

# Note: These examples do not set authentication details, see the AWS Guide for details.

- aws_msk_config:
- msk_config:
name: kafka-cluster-configuration
state: present
kafka_versions:
Expand All @@ -327,7 +328,7 @@ Examples
default.replication.factor: 3
zookeeper.session.timeout.ms: 18000

- aws_msk_config:
- msk_config:
name: kafka-cluster-configuration
state: absent

Expand Down
8 changes: 8 additions & 0 deletions meta/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ action_groups:
- lambda_policy
- lightsail
- lightsail_static_ip
- msk_cluster
- msk_config
- networkfirewall
- networkfirewall_info
- networkfirewall_policy
Expand Down Expand Up @@ -330,6 +332,12 @@ plugin_routing:
aws_kms_info:
# Deprecation for this alias should not *start* prior to 2024-09-01
redirect: community.aws.kms_key_info
aws_msk_cluster:
# Deprecation for this alias should not *start* prior to 2024-09-01
redirect: community.aws.msk_cluster
aws_msk_config:
# Deprecation for this alias should not *start* prior to 2024-09-01
redirect: community.aws.msk_config
aws_s3_bucket_info:
# Deprecation for this alias should not *start* prior to 2024-09-01
redirect: community.aws.s3_bucket_info
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@

DOCUMENTATION = r"""
---
module: aws_msk_cluster
module: msk_cluster
short_description: Manage Amazon MSK clusters
version_added: "2.0.0"
description:
- Create, delete and modify Amazon MSK (Managed Streaming for Apache Kafka) clusters.
- Prior to release 5.0.0 this module was called C(community.aws.aws_msk_cluster).
The usage did not change.
author:
- Daniil Kupchenko (@oukooveu)
options:
Expand All @@ -31,7 +33,6 @@
- The version of Apache Kafka.
- This version should exist in given configuration.
- This parameter is required when I(state=present).
- Update operation requires botocore version >= 1.16.19.
type: str
configuration_arn:
description:
Expand Down Expand Up @@ -212,7 +213,7 @@
EXAMPLES = r"""
# Note: These examples do not set authentication details, see the AWS Guide for details.

- aws_msk_cluster:
- community.aws.msk_cluster:
name: kafka-cluster
state: present
version: 2.6.1
Expand All @@ -227,7 +228,7 @@
configuration_arn: arn:aws:kafka:us-east-1:000000000001:configuration/kafka-cluster-configuration/aaaaaaaa-bbbb-4444-3333-ccccccccc-1
configuration_revision: 1

- aws_msk_cluster:
- community.aws.msk_cluster:
name: kafka-cluster
state: absent
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@

DOCUMENTATION = r"""
---
module: aws_msk_config
short_description: Manage Amazon MSK cluster configurations.
module: msk_config
short_description: Manage Amazon MSK cluster configurations
version_added: "2.0.0"
description:
- Create, delete and modify Amazon MSK (Managed Streaming for Apache Kafka) cluster configurations.
- Prior to release 5.0.0 this module was called C(community.aws.aws_msk_config).
The usage did not change.
author:
- Daniil Kupchenko (@oukooveu)
options:
Expand Down Expand Up @@ -47,7 +49,7 @@
EXAMPLES = r"""
# Note: These examples do not set authentication details, see the AWS Guide for details.

- aws_msk_config:
- community.aws.msk_config:
name: kafka-cluster-configuration
state: present
kafka_versions:
Expand All @@ -59,7 +61,7 @@
default.replication.factor: 3
zookeeper.session.timeout.ms: 18000

- aws_msk_config:
- community.aws.msk_config:
name: kafka-cluster-configuration
state: absent
"""
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/targets/aws_msk_cluster/aliases

This file was deleted.

4 changes: 0 additions & 4 deletions tests/integration/targets/aws_msk_config/aliases

This file was deleted.

1 change: 1 addition & 0 deletions tests/integration/targets/msk_cluster/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cloud/aws
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ vpc_subnets:
- '10.{{ 256 | random(seed=resource_prefix) }}.101.0/24'
vpc_subnet_name_prefix: "{{ resource_prefix }}"

msk_config_name: "{{ resource_prefix }}-config"
msk_config_name: "{{ resource_prefix }}-msk-cluster"
msk_cluster_name: "{{ tiny_prefix }}-msk-cluster"
msk_version: 2.6.0
msk_broker_nodes: 2
Expand Down
1 change: 1 addition & 0 deletions tests/integration/targets/msk_config/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cloud/aws
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
msk_config_name: "{{ resource_prefix }}-config"
msk_config_name: "{{ resource_prefix }}-msk-config"
msk_configs:
- auto.create.topics.enable: true
zookeeper.session.timeout.ms: 18000
Expand Down