nsupdate: issues/4657 #5377
Merged
nsupdate: issues/4657 #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for your contribution! Could you please add a changelog fragment? Thanks. |
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
|
Please note that the issues in #5377 (comment) are still waiting to be resolved. |
Fixed lint
Co-authored-by: Felix Fontein <[email protected]>
Simon-TheUser
force-pushed
the
issues/4657
branch
from
8c5c2c4 to
71c0729
Compare
|
I hope I did the rebase correctly. |
ansibullbot
added
net_tools
plugins
|
@Simon-TheUser looks good, thank you! Now also the bot informed the module maintainer. |
|
If nobody complains, I'll merge this by the end of this week. |
felixfontein
removed
the
check-before-release
|
Sorry, defining now as the end of week ;) |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5460 🤖 @patchback |
|
@Simon-TheUser thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Insert new entries before deleting old ones. resolves #4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5cb9a9e)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Insert new entries before deleting old ones. resolves #4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5cb9a9e) Co-authored-by: Simon-TheUser <[email protected]>
rekup
pushed a commit
to rekup/community.general
that referenced
this pull request
Nov 3, 2022
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 10, 2022
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #4657
The "modify_record" method of the nsupdate module uses a delete-first approach to DNS updates. This prevents any updates to the NS records against Bind9 DNS servers.
This MR changes this behavior where updates to NS records will insert and update existing records, then perform the deletes.
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nsupdate.py
ADDITIONAL INFORMATION
I have been using this patch in my infrastructure for 2 months without any side issues.