[PR #5377/5cb9a9e4 backport][stable-5] nsupdate: issues/4657 #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Insert new entries before deleting old ones. resolves #4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5cb9a9e)
Merged
felixfontein
deleted the
patchback/backports/stable-5/5cb9a9e4f0ff68670e5aa285263c01227b03d8af/pr-5377
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5377 as merged into main (5cb9a9e).
SUMMARY
Fixes #4657
The "modify_record" method of the nsupdate module uses a delete-first approach to DNS updates. This prevents any updates to the NS records against Bind9 DNS servers.
This MR changes this behavior where updates to NS records will insert and update existing records, then perform the deletes.
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nsupdate.py
ADDITIONAL INFORMATION
I have been using this patch in my infrastructure for 2 months without any side issues.