Adding PUT functionality to redfish_utils.py #5490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSKushal
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
|
Looks good to me |
ansibullbot
removed
the
needs_revision
felixfontein
added
the
check-before-release
|
Thanks for your contribution! Can you please add a changelog fragment? Thanks. |
|
@TSKushal this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
felixfontein
reviewed
Nov 8, 2022
|
@TSKushal this PR contains the following merge commits: Please rebase your branch to remove these commits. |
The previous error message was not giving the full or even correct information to the user.
…s#4457) * add support for datadog monitors of type event-v2 See https://docs.datadoghq.com/events/guides/migrating_to_new_events_features/ * add changelog fragement for PR * typos * add link to PR * minor_fetaure, not bugfix * add to description when we added event-v2 type * Update changelogs/fragments/4457-support-datadog-monitors-type event-v2.yaml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
…-collections#4458) * Redfish: Added IndicatorLED commands to the Systems category Signed-off-by: Mike Raineri <[email protected]> * Method call typo fix Signed-off-by: Mike Raineri <[email protected]> * Update 4084-add-redfish-system-indicator-led.yml * Backwards compatibility suggestion Signed-off-by: Mike Raineri <[email protected]>
* Implement btrfs resize support * Add changelog fragment for btrfs resize support Co-authored-by: Fabian Klemp <[email protected]>
…-collections#4459) * Only get monitor if it is not null api response * Add changelog fragment * Update changelogs/fragments/4459-only-get-monitor-if-it-is-not-null-api-response.yaml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/net_tools/dnsmadeeasy.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: drevai <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
* Adds optional `-upgrade` flag to terraform init. This allows Terraform to install provider dependencies into an existing project when the provider constraints change. * fix transposed documentation keys * Add integration tests for terraform init * Revert to validate_certs: yes for general public testing * skip integration tests on irrelevant platforms * skip legacy Python versions from CI tests * add changelog fragment * Update plugins/modules/cloud/misc/terraform.py Adds version_added metadata to the new module option. Co-authored-by: Felix Fontein <[email protected]> * Change terraform_arch constant to Ansible fact mapping * correct var typo, clarify task purpose * Squashed some logic bugs, added override for local Terraform If `existing_terraform_path` is provided, the playbook will not download Terraform or check its version. I also tested this on a local system with Terraform installed, and squashed some bugs related to using of an existing binary. * revert to previous test behavior for TF install * readability cleanup * Update plugins/modules/cloud/misc/terraform.py Co-authored-by: Felix Fontein <[email protected]>
If `all=True` is not set then by default only 20 records will be returned when calling `list()`. Use `all=True` so that all records will be returned. For the `list()` use where do not desire to retrieve all entries then use`all=False` to show explicityly that we don't want to get all of the entries. Fixes: ansible-collections#3729 Fixes: ansible-collections#4460
…4464) * pacman: Fix removing locally installed packages Without this, using `absent` state for a locally installed package (for example from AUR, or from a package that was dropped from repositories) would return that package is already removed, despite remaining installed * Undo unwanted whitespace removal * Add changelog fragment * Update changelogs/fragments/4464-pacman-fix-local-remove.yaml Co-authored-by: Felix Fontein <[email protected]> * Add test. Co-authored-by: Felix Fontein <[email protected]>
…ecate this in 4.0.0. (ansible-collections#4515)
…ons#5405) * deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <[email protected]> * minor change to help future removal of feature Co-authored-by: Felix Fontein <[email protected]>
* MH CmdModuleHelper: deprecation * add changelog fragment * add deprecation comments in many parts of the code
* Send string instead of boolean to proxmox api * Add changelog fragment. * Update plugins/modules/cloud/misc/proxmox_kvm.py Co-authored-by: castorsky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: castorsky <[email protected]>
* Update jc.py ##### SUMMARY <!— Your description here –> ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update jc.py * Update jc.py * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * change all of the tags to be FQMN FQMN = fully qualified module name * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update jc.py * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update jc.py * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/jc.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
* search_s based _is_value_present
* Fix formatted string and ldap import
* Add changelog fragment
* Remove superfluous import ldap
* Improve fragment
* Code format {x} prefix
* Lower-case fixes
* Fix suggestions to changelog
* Break with the past and let bools be bools
* Let ldap_attrs break on invalid DN's
* remove redundant templar is already in base class env var is already consulted in via config resolution * more whites * no need to import templar again * Add changelog fragment. * Try to update tests. Co-authored-by: Felix Fontein <[email protected]>
…tions#5437) * remove redundant and simplify code we already have a templar from base class loop reuses code instead of X copies of it * whitey * no need to import templar again * Add changelog fragment. Co-authored-by: Felix Fontein <[email protected]>
…ollections#5425) * Redfish: centralize payload checking when performing modification requests to a Redfish service * CI fixes * Updates based on unit testing * CI fix * Modified vendor-specific logic to establish common pattern for workarounds
* Clearer error logging in passwordstore lookup * Add changelog fragment for passwordstore errmsgs Co-authored-by: Sylvia van Os <[email protected]>
* Insert new entries before deleting old ones. resolves ansible-collections#4657 * Slight wording changes. * lint fix * Address lint * Added changelog Fixed lint * More linting * Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
) * Allow for DN's to have {x} prefix on first RDN * Update changelogs/fragments/5450-allow-for-xordered-dns.yaml Co-authored-by: Felix Fontein <[email protected]> * Assign attrs to throw-away var * Update plugins/module_utils/ldap.py Co-authored-by: Felix Fontein <[email protected]> * Escape DN before creating filter Co-authored-by: Felix Fontein <[email protected]>
* [Scaleway] Add module to manage function Signed-off-by: Lunik <[email protected]> * fix integration tests assertions Signed-off-by: Lunik <[email protected]> * Update plugins/modules/scaleway_function.py Co-authored-by: Felix Fontein <[email protected]> Signed-off-by: Lunik <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
TSKushal
force-pushed
the
redfish_utils_update
branch
from
28d5549 to
0d219b4
Compare
|
This PR got closed due to certain issues. Raising a new PR 5507. Apologies for the inconvenience. |
felixfontein
removed
the
check-before-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding PUT functionality to redfish_utils.py
ISSUE TYPE
COMPONENT NAME
redfish_utils.py
ADDITIONAL INFORMATION
This was raised as part of PR 5328, but raising it here to allow for easy merge. Will remove it from the old PR.