call ensure-tox role before tox #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2020
pabelanger
reviewed
May 14, 2020
| @@ -11,6 +11,10 @@ | |||
| _network_os: "{{ hostvars[groups['openvswitch'][0]]['ansible_network_os'] }}" | |||
| when: '"openvswitch" in groups' | |||
|
|
|||
| - name: Ensure tox | |||
There was a problem hiding this comment.
I feel this is fine, again we should only need to limit to aws nodes. As tox is managed via DIB. The fear I have, is we overwrite DIBs setup and manage if tox
The `tox` role assumes the command is available.
|
We should not need that anyway thanks to https://review.opendev.org/#/c/727561/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toxrole assumes the command is available.