Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call ensure-tox role before tox #463

Closed
wants to merge 1 commit into from
Closed

call ensure-tox role before tox #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions playbooks/ansible-test-network-integration-base/pre.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
_network_os: "{{ hostvars[groups['openvswitch'][0]]['ansible_network_os'] }}"
when: '"openvswitch" in groups'

- name: Ensure tox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is fine, again we should only need to limit to aws nodes. As tox is managed via DIB. The fear I have, is we overwrite DIBs setup and manage if tox

include_role:
name: ensure-tox
when: "'aws' in group_names"

- name: Setup tox role
include_role:
name: tox
Expand Down